Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbt compile help text is missing a comma #2388

Closed
1 of 5 tasks
sethwoodworth opened this issue May 1, 2020 · 0 comments · Fixed by #2389
Closed
1 of 5 tasks

dbt compile help text is missing a comma #2388

sethwoodworth opened this issue May 1, 2020 · 0 comments · Fixed by #2389
Labels
bug Something isn't working good_first_issue Straightforward + self-contained changes, good for new contributors!

Comments

@sethwoodworth
Copy link
Contributor

Describe the bug

dbt -h outputs:

...
    compile             Generates executable SQL from source model, test, and
                        analysis files. Compiled SQL files are written to the
                        target/ directory.
...

but a 'source model' is not a construct within dbt, there are sources and models.

Steps To Reproduce

dbt -h

Expected behavior

I'd expect a comma between each object the help text describes, especially since the oxford comma is used before the word 'and'

System information

Which database are you using dbt with?

  • postgres
  • redshift
  • bigquery
  • snowflake
  • other (specify: ____________)

The output of dbt --version:

installed version: 0.15.1

(but this is still true in dbt 0.16.x and in the current master branch)
The operating system you're using:
debian buster
The output of python --version:
Python 3.7.4.

@sethwoodworth sethwoodworth added bug Something isn't working triage labels May 1, 2020
@drewbanin drewbanin added good_first_issue Straightforward + self-contained changes, good for new contributors! and removed triage labels May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good_first_issue Straightforward + self-contained changes, good for new contributors!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants