Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lower bound on google-api-core, or google-cloud-core, or both #2233

Closed
drewbanin opened this issue Mar 23, 2020 · 1 comment
Closed

Add lower bound on google-api-core, or google-cloud-core, or both #2233

drewbanin opened this issue Mar 23, 2020 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@drewbanin
Copy link
Contributor

Describe the bug

From Slack:

Just upgraded to dbt=0.16.0 and got the following error message when running:
$ dbt run --models analytics_table
Running with dbt=0.16.0
Error importing adapter: No module named 'google.api_core.client_options'
Encountered an error:
No module named 'google.api_core.client_options'

It looks like client_options was added in 1.13.0, but the user above had v0.12.0 installed.

Let's check out the requirements of google-cloud-core and google-cloud-bigquery. I think we may need to bump the minimum version of google-cloud-core in order to support:

  • client_options (via google-api-core)
  • the timeout argument to api_request (also per Slack)

Users' env:

$ pip freeze | grep google
google-api-core==1.12.0
google-auth==1.11.3
google-cloud-bigquery==1.24.0
google-cloud-core==1.0.2
google-resumable-media==0.5.0
googleapis-common-protos==1.6.0
@drewbanin drewbanin added the bug Something isn't working label Mar 23, 2020
@drewbanin drewbanin added this to the 0.16.1 milestone Mar 23, 2020
@drewbanin drewbanin changed the title Add lower bound on google-api-core Add lower bound on google-api-core, or google-cloud-core, or both Mar 23, 2020
beckjake added a commit that referenced this issue Mar 26, 2020
…-bound

rev the bigquery minimum versions to a big number (#2233)
@beckjake
Copy link
Contributor

Fixed in #2249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants