-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can not deploy gen2 trigger cloud functions with custom service account #6814
Comments
Starting in this week's release, the |
@inlined First of all thanks for the fixes, secondly I can confirm onSchedule, beforeUserCreated and beforeUserSignedIn to work now with the latest firebase-tools version, but still get the error of default compute-engine SA not existing when deploying onDocumentWritten trigger functions. Let me know if you want me to create a new issue about this. |
Will look into it this week. Also, FYI, I've submitted a proposal to add |
@inlined any progress on this? At least have not spotted any fixes yet in the release notes regarding this. We are currently stuck in gen1/gen2 hybrid setup because of this issue so even not super critical would be really nice to be able to move fully to gen2 stuff. Thank you again for looking into this. |
We ran into this issue as well. Even though the function now supports specifying custom service accounts, it seems Firebase CLI (
firebase-tools/src/deploy/functions/checkIam.ts Lines 156 to 157 in e1ff423
|
Environment info
firebase-tools: 13.3.1
Platform: Debian
Test case
This happens also with onDocument* firestore triggers, basically anything that uses EventArc. GCloud tool seems to have separate trigger-service-account input argument so it is at least possible to define the service account to be used, but can not get it to work with firebase cloud functions. Have tried using the setGlobalOptions as well, but no luck with that neither.
This used to be an issue with the onCall and onRequest as well, but those now work with the latest version of firebase-tools.
Steps to reproduce
Have any kind of trigger cloud function and configure it to use custom service account and have a project that does not have the default compute engine service account which EventArc uses when no service account is defined.
Expected behavior
Deploy works without the error about missing default compute engine service account and the defined service account is used.
Actual behavior
The text was updated successfully, but these errors were encountered: