Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate husky install to npm prepare hook #188

Closed
JamieSlome opened this issue Jul 4, 2023 · 2 comments · Fixed by #196
Closed

Migrate husky install to npm prepare hook #188

JamieSlome opened this issue Jul 4, 2023 · 2 comments · Fixed by #196
Assignees
@vaibssingh
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@JamieSlome
Copy link
Member

When developers contribute clone this repository, commitlint is not guaranteed to scan commits via husky.

With the new preinstall hook running npx husky install a better approach has been recommended with the prepare hook.

The following walkthrough can be followed to address the issue: https://sonspring.com/journal/husky-v5-and-npm-prepare/
@JamieSlome JamieSlome added bug Something isn't working good first issue Good for newcomers labels Jul 4, 2023
@JamieSlome JamieSlome mentioned this issue Jul 4, 2023
Merged
@vaibssingh
Copy link
Contributor

Hey @JamieSlome, can I take this up? 😄

@JamieSlome
Copy link
Member Author

@vaibssingh go for it!

@vaibssingh vaibssingh mentioned this issue Jul 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaibssingh vaibssingh

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add prepare hook for husky install vaibssingh/git-proxy
2 participants
@vaibssingh @JamieSlome