Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue: update go-libp2p to v0.25 #10199

Closed
22 of 28 tasks
marten-seemann opened this issue Feb 7, 2023 · 2 comments
Closed
22 of 28 tasks

Tracking Issue: update go-libp2p to v0.25 #10199

marten-seemann opened this issue Feb 7, 2023 · 2 comments
Assignees
Labels
kind/enhancement Kind: Enhancement

Comments

@marten-seemann
Copy link
Contributor

marten-seemann commented Feb 7, 2023

Checklist

  • This is not a new feature or an enhancement to the Filecoin protocol. If it is, please open an FIP issue.
  • This is not a new feature request. If it is, please file a feature request instead.
  • This is not brainstorming ideas. If you have an idea you'd like to discuss, please open a new discussion on the lotus forum and select the category as Ideas.
  • I have a specific, actionable, and well motivated improvement to propose.

Lotus component

  • lotus daemon - chain sync
  • lotus miner - mining and block production
  • lotus miner/worker - sealing
  • lotus miner - proving(WindowPoSt)
  • lotus miner/market - storage deal
  • lotus miner/market - retrieval deal
  • lotus miner/market - data transfer
  • lotus client
  • lotus JSON-RPC API
  • lotus message management (mpool)
  • Other

Improvement Suggestion

The next go-libp2p update will require some more work, since we'll need to completely get rid of the (now deprecated) go-libp2p-core. go-libp2p-core was moved into go-libp2p as part of our mono-repo consolidation effort. Due to subsequent changes made to the core interfaces, go build will now fail even if there's any (transitive or non-transitive) dependency on go-libp2p-core.
This means we'll need to update all Lotus dependencies to not use go-libp2p-core any more. This is a painful exercise, but it has to be done once. The good news is that updating go-libp2p in the future will be much easier since as a mono-repo, there are less failure points.

Updating to v0.25 will be required to build with Go 1.20.

This list is not complete yet. I'll add links to PRs here when they are created.

@marten-seemann marten-seemann changed the title Tracking Issue: update go-libp2p to >= v0.24 Tracking Issue: update go-libp2p to v0.25 Feb 11, 2023
@rjan90
Copy link
Contributor

rjan90 commented May 2, 2023

Hey @marten-seemann! Can this issue be closed now as the go-libp2p version is on track to be updated to v0.27.1 (#10671)?

@marten-seemann
Copy link
Contributor Author

Yes, Lotus is on v0.26.3, so this issue has been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Kind: Enhancement
Projects
None yet
Development

No branches or pull requests

3 participants