Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LID web UI: don't look up cid by root payload cid #1716

Closed
dirkmc opened this issue Sep 26, 2023 · 0 comments · Fixed by #1721
Closed

LID web UI: don't look up cid by root payload cid #1716

dirkmc opened this issue Sep 26, 2023 · 0 comments · Fixed by #1721
Assignees

Comments

@dirkmc
Copy link
Contributor

dirkmc commented Sep 26, 2023

In the LID web UI, the SP can look up a cid in the search box.

It will look up the cid as a payload cid by searching

  1. in the LID payload cid -> piece cid index
  2. in the boostd sqlite database by root payload cid (deal data root cid).

In practice it is confusing to lookup the cid by root payload cid (the deal's Label field) in the boostd sqlite database. It can give the SP the impression that the deal label field corresponds to a payload cid, when that may not actually be the case.

If the user wants to search by the deal's Label field they can already do this using the search box on the Storage Deals list page.

We should remove the code that looks up the cid by root payload cid in the web UI, including removing it from the graphql endpoint (resolver).

Screenshot 2023-09-26 at 11 52 19 AM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants