Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/41 tests are dependent on local timezone settings #107

Conversation

janekelin
Copy link

It should resolve #41. Our team has added also some additional tests that should highlight the real problem.

@chase-manning
Copy link
Collaborator

@jamiebuilds Hi Jane, thanks so much for this PR, this is super cool!!!
Sorry this was not merged sooner, the repo was not being actively maintained at the time.
I would love to merge this now, but I see that there are some failed tests and some merge conflicts.
Would you be okay to please fix these so I can merge?

FYI: @nirfeltf24s & @michaelsanford

@janekelin
Copy link
Author

Hey, @chase-manning ! Sorry for the enormously delayed answer. This PR was a part of our educational programme in our organization, and the Corona pandemic disrupted both this flow and our working processes. I will close this PR for now, and when the team would be ready for a new attempt, we would send a new PR!

@janekelin janekelin closed this Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are dependent on local timezone settings
4 participants