Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] SQLAlchemy Exception when using Enums and jsonable_encoder #21

Closed
ebreton opened this issue May 1, 2019 · 6 comments
Closed

[BUG] SQLAlchemy Exception when using Enums and jsonable_encoder #21

ebreton opened this issue May 1, 2019 · 6 comments

Comments

@ebreton
Copy link
Contributor

ebreton commented May 1, 2019

Issue added for reference.

@tiangolo
Copy link
Member

Thanks, I'll check it.

@AnneNamuli
Copy link

I am having almost the same issue.. I keep getting validation errors when i use enum type

@ebreton
Copy link
Contributor Author

ebreton commented Sep 9, 2019

I am working on it, and got it running with CrudBase. I will update #23 accordingly asap.

I still have one limit though, which is using the same string for name and value.

  • value because it is used by pydantic
  • name because it is used by SQLalchemy

I keep you posted...

@AnneNamuli
Copy link

Thanks!!

@tiangolo
Copy link
Member

I think this was solved in your PR right @ebreton ? 🤓 🚀

May we close it?

@ebreton
Copy link
Contributor Author

ebreton commented Apr 12, 2020

You are right @tiangolo, thanks for the clean-keeping work. And for the whole fastapi ecosystem. It rocks 🌟 💎

@ebreton ebreton closed this as completed Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants