Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactoring] Make Velox support Parquet thrift code generation #1622

Closed
yingsu00 opened this issue May 14, 2022 · 1 comment
Closed

[Refactoring] Make Velox support Parquet thrift code generation #1622

yingsu00 opened this issue May 14, 2022 · 1 comment

Comments

@yingsu00
Copy link
Collaborator

This is a sub issue of #1533

We will make the Parquet thrift cpp code automatically generated. The thrift definition is from https://github.com/apache/parquet-cpp/blob/master/src/parquet/parquet.thrift . This is similar to Protobuf for DWRF: velox/dwio/dwrf/proto

Note that we may need to install fb-thrift in Velox. This requires us to update the setup scripts.

@stale
Copy link

stale bot commented Sep 14, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Sep 14, 2022
@stale stale bot closed this as completed Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants