Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace support has broken the example and it's unclear how to proceed #27

Closed
thoughtpolice opened this issue Aug 21, 2023 · 4 comments

Comments

@thoughtpolice
Copy link

thoughtpolice commented Aug 21, 2023

After #22 was implemented (in f2145de), I'm confused on how to update my Cargo.toml in order to work with reindeer buckify anymore. Absolutely everything I have tried results in the following error:

[ERROR reindeer] parsing metadata
    
    Caused by:
        0: deserializing json
        1: missing field `workspace_default_members` at line 1 column 40613

This exact same error occurs when you attempt to run reindeer buckify on the given examples/ directory Cargo.toml as well. I tried splitting and putting things in workspaces.default-members and several other things; nothing has changed this error at all.

The version of Reindeer is from Nixpkgs; it was built as of commit 7ab6fc8.

@dtolnay
Copy link

dtolnay commented Aug 21, 2023

Are you using an old cargo? workspace_default_members has been present since 1.71.

@thoughtpolice
Copy link
Author

Oh, I was using 1.70, which would explain it then. I can upgrade and try again.

@dtolnay
Copy link

dtolnay commented Aug 21, 2023

Great! Alternatively we'd take a PR to make it work with 1.70 too.

@thoughtpolice
Copy link
Author

I've tested it, and moving to 1.71 does indeed fix it with no changes to Cargo.toml! Thanks for that.

As for closing this and moving forward, I could try to submit a PR to make it work with previous versions, but I'm rather busy right now and may not have time for it; in the meantime it might also be good to warn in the README at least that you need a recent Cargo.

@dtolnay dtolnay closed this as completed Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants