Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the output of scripts/init.js #629

Merged
merged 2 commits into from
Sep 11, 2016

Conversation

btnwtn
Copy link
Contributor

@btnwtn btnwtn commented Sep 11, 2016

@fson Ran into major problems with git trying to merge this pull-request:
#363

@ghost ghost added the CLA Signed label Sep 11, 2016
console.log();
console.log(chalk.cyan('npm run eject'));
console.log(' Removes this tool and copies build dependencies, configs,')
console.log(' and scripts into the app directory.')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this line and the one above it are missing semicolons in the end, can you add them back? Otherwise everything seems to be in order now 👌

@btnwtn
Copy link
Contributor Author

btnwtn commented Sep 11, 2016

Fixed 😄

@fson
Copy link
Contributor

fson commented Sep 11, 2016

Great, thanks for pulling it through! 👍

@fson fson merged commit 989fd85 into facebook:master Sep 11, 2016
console.log(' Bundles the app into static files for production.');
console.log();
console.log(chalk.cyan('npm run eject'));
console.log(' Removes this tool and copies build dependencies, configs,');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fson Can you please change "configs" to "configuration files" directly in master? I'd like to avoid jargon in messages.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@btnwtn btnwtn deleted the improve-npm-descriptions branch September 12, 2016 18:29
@gaearon gaearon mentioned this pull request Sep 18, 2016
feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
* Improve the output of scripts/init.js

* Add semi-colons;
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants