Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

equality checking in recycleNodesInto.js #2287

Closed
chungwong opened this issue Jan 18, 2018 · 1 comment
Closed

equality checking in recycleNodesInto.js #2287

chungwong opened this issue Jan 18, 2018 · 1 comment

Comments

@chungwong
Copy link

These 3 lines were added at efd18d6 to fix read only property warning.

Given that
[1] == [1] evaluates false, this checking will fail on arrays which means the 3-line guard added will not work on arrays and will trigger

Uncaught TypeError: Cannot assign to read only property 'foo' of object '#<Object>'
@alloy
Copy link
Contributor

alloy commented Jan 29, 2018

This is essentially a duplicate of #2049 and PR #2193 already exists to address it.

@jstejada This can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants