Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[relay-compiler] should formatGeneratedModule be publicly exported #1927

Closed
robrichard opened this issue Jun 29, 2017 · 2 comments
Closed

[relay-compiler] should formatGeneratedModule be publicly exported #1927

robrichard opened this issue Jun 29, 2017 · 2 comments

Comments

@robrichard
Copy link
Contributor

I have built my own version of relay-compiler by copying and modifying RelayCompilerBin to work around the limitations with using fragments from node_modules (see #1921).

As of relay-compiler@1.1.0 formatModule option is required for RelayFileWriter and the default is to pass in formatGeneratedModule. If the intention is to allow people to build their own customized relay-compiler, should formatGeneratedModule be exported in RelayCompilerPublic?

@zth
Copy link
Contributor

zth commented Jul 5, 2017

I'm also very interested in this. Due to current limitations of IntelliJ I need to make Relay Compiler output the Flow types without wrapping them in comments. I guess this would help with that too?

@kassens
Copy link
Member

kassens commented Aug 23, 2017

@zth: Yes, you probably want to copy the code from formatGeneratedModule and make the change to the output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants