From 4113aa92d4971d79b00ae42761c5029c5ba72552 Mon Sep 17 00:00:00 2001
From: raunofreiberg <freiberggg@gmail.com>
Date: Fri, 10 Aug 2018 15:42:31 +0300
Subject: [PATCH 01/11] refactor: move getSafeValue to separate file

---
 .../src/client/ReactDOMFiberInput.js          |  1 +
 packages/react-dom/src/client/getSafeValue.js | 22 +++++++++++++++++++
 2 files changed, 23 insertions(+)
 create mode 100644 packages/react-dom/src/client/getSafeValue.js

diff --git a/packages/react-dom/src/client/ReactDOMFiberInput.js b/packages/react-dom/src/client/ReactDOMFiberInput.js
index 51bcf215021c9..0f15e7e97cd00 100644
--- a/packages/react-dom/src/client/ReactDOMFiberInput.js
+++ b/packages/react-dom/src/client/ReactDOMFiberInput.js
@@ -17,6 +17,7 @@ import {getFiberCurrentPropsFromNode} from './ReactDOMComponentTree';
 import {getToStringValue, toString} from './ToStringValue';
 import ReactControlledValuePropTypes from '../shared/ReactControlledValuePropTypes';
 import * as inputValueTracking from './inputValueTracking';
+import getSafeValue from './getSafeValue';
 
 import type {ToStringValue} from './ToStringValue';
 
diff --git a/packages/react-dom/src/client/getSafeValue.js b/packages/react-dom/src/client/getSafeValue.js
new file mode 100644
index 0000000000000..71d79739b63e1
--- /dev/null
+++ b/packages/react-dom/src/client/getSafeValue.js
@@ -0,0 +1,22 @@
+/**
+ * Copyright (c) 2015-present, Facebook, Inc.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @flow
+ */
+
+export default function getSafeValue(value: *): * {
+  switch (typeof value) {
+    case 'boolean':
+    case 'number':
+    case 'object':
+    case 'string':
+    case 'undefined':
+      return value;
+    default:
+      // function, symbol are assigned as empty strings
+      return '';
+  }
+}

From 57f34d65ef61b052a6590d9f4a908d55f354822d Mon Sep 17 00:00:00 2001
From: raunofreiberg <freiberggg@gmail.com>
Date: Fri, 10 Aug 2018 15:43:24 +0300
Subject: [PATCH 02/11] fix(?): ReactDOMFiberTextarea sanitization for symbols
 and functions

---
 .../src/__tests__/ReactDOMTextarea-test.js    | 132 ++++++++++++++++--
 .../src/client/ReactDOMFiberTextarea.js       |  11 +-
 2 files changed, 127 insertions(+), 16 deletions(-)

diff --git a/packages/react-dom/src/__tests__/ReactDOMTextarea-test.js b/packages/react-dom/src/__tests__/ReactDOMTextarea-test.js
index b2872d92b503f..586042a99cf9b 100644
--- a/packages/react-dom/src/__tests__/ReactDOMTextarea-test.js
+++ b/packages/react-dom/src/__tests__/ReactDOMTextarea-test.js
@@ -20,6 +20,8 @@ describe('ReactDOMTextarea', () => {
   let renderTextarea;
 
   beforeEach(() => {
+    jest.resetModules();
+
     React = require('react');
     ReactDOM = require('react-dom');
     ReactDOMServer = require('react-dom/server');
@@ -200,18 +202,6 @@ describe('ReactDOMTextarea', () => {
     expect(node.value).toBe('0');
   });
 
-  it('should take updates to children in lieu of `defaultValue` for uncontrolled textarea', () => {
-    const container = document.createElement('div');
-
-    const node = ReactDOM.render(<textarea defaultValue="0" />, container);
-
-    expect(node.value).toBe('0');
-
-    ReactDOM.render(<textarea>1</textarea>, container);
-
-    expect(node.value).toBe('0');
-  });
-
   it('should not incur unnecessary DOM mutations', () => {
     const container = document.createElement('div');
     ReactDOM.render(<textarea value="a" onChange={emptyFunction} />, container);
@@ -423,4 +413,122 @@ describe('ReactDOMTextarea', () => {
     ReactDOM.unmountComponentAtNode(container);
     ReactDOM.render(<textarea value={undefined} />, container);
   });
+
+  describe('When given a Symbol value', () => {
+    it('treats initial Symbol value as an empty string', () => {
+      const container = document.createElement('div');
+      expect(() =>
+        ReactDOM.render(
+          <textarea value={Symbol('foobar')} onChange={() => {}} />,
+          container,
+        ),
+      ).toWarnDev('Invalid value for prop `value`');
+      const node = container.firstChild;
+
+      expect(node.value).toBe('');
+    });
+
+    it('treats initial Symbol children as an empty string', () => {
+      const container = document.createElement('div');
+      expect(() =>
+        ReactDOM.render(
+          <textarea onChange={() => {}}>{Symbol('foo')}</textarea>,
+          container,
+        ),
+      ).toWarnDev('Use the `defaultValue` or `value` props');
+      const node = container.firstChild;
+
+      expect(node.value).toBe('');
+    });
+
+    it('treats updated Symbol value as an empty string', () => {
+      const container = document.createElement('div');
+      ReactDOM.render(<textarea value="foo" onChange={() => {}} />, container);
+      expect(() =>
+        ReactDOM.render(
+          <textarea value={Symbol('foo')} onChange={() => {}} />,
+          container,
+        ),
+      ).toWarnDev('Invalid value for prop `value`');
+      const node = container.firstChild;
+
+      expect(node.value).toBe('');
+    });
+
+    it('treats initial Symbol defaultValue as an empty string', () => {
+      const container = document.createElement('div');
+      ReactDOM.render(<textarea defaultValue={Symbol('foobar')} />, container);
+      const node = container.firstChild;
+
+      expect(node.value).toBe('');
+    });
+
+    it('treats updated Symbol defaultValue as an empty string', () => {
+      const container = document.createElement('div');
+      ReactDOM.render(<textarea defaultValue="foo" />, container);
+      ReactDOM.render(<textarea defaultValue={Symbol('foobar')} />, container);
+      const node = container.firstChild;
+
+      expect(node.value).toBe('foo');
+    });
+  });
+
+  describe('When given a function value', () => {
+    it('treats initial function value as an empty string', () => {
+      const container = document.createElement('div');
+      expect(() =>
+        ReactDOM.render(
+          <textarea value={() => {}} onChange={() => {}} />,
+          container,
+        ),
+      ).toWarnDev('Invalid value for prop `value`');
+      const node = container.firstChild;
+
+      expect(node.value).toBe('');
+    });
+
+    it('treats initial function children as an empty string', () => {
+      const container = document.createElement('div');
+      expect(() =>
+        ReactDOM.render(
+          <textarea onChange={() => {}}>{() => {}}</textarea>,
+          container,
+        ),
+      ).toWarnDev('Use the `defaultValue` or `value` props');
+      const node = container.firstChild;
+
+      expect(node.value).toBe('');
+    });
+
+    it('treats updated function value as an empty string', () => {
+      const container = document.createElement('div');
+      ReactDOM.render(<textarea value="foo" onChange={() => {}} />, container);
+      expect(() =>
+        ReactDOM.render(
+          <textarea value={() => {}} onChange={() => {}} />,
+          container,
+        ),
+      ).toWarnDev('Invalid value for prop `value`');
+      const node = container.firstChild;
+
+      expect(node.value).toBe('');
+    });
+
+    it('treats initial function defaultValue as an empty string', () => {
+      const container = document.createElement('div');
+      ReactDOM.render(<textarea defaultValue={() => {}} />, container);
+      const node = container.firstChild;
+
+      expect(node.value).toBe('');
+    });
+
+    it('treats updated function defaultValue as an empty string', () => {
+      const container = document.createElement('div');
+      ReactDOM.render(<textarea defaultValue="foo" />, container);
+      ReactDOM.render(<textarea defaultValue={() => {}} />, container);
+      const node = container.firstChild;
+
+      expect(node.value).toBe('foo');
+    });
+  });
 });
diff --git a/packages/react-dom/src/client/ReactDOMFiberTextarea.js b/packages/react-dom/src/client/ReactDOMFiberTextarea.js
index ce6e0f7f0cb3b..0a59182157a2c 100644
--- a/packages/react-dom/src/client/ReactDOMFiberTextarea.js
+++ b/packages/react-dom/src/client/ReactDOMFiberTextarea.js
@@ -11,6 +11,7 @@ import invariant from 'shared/invariant';
 import warning from 'shared/warning';
 
 import ReactControlledValuePropTypes from '../shared/ReactControlledValuePropTypes';
+import getSafeValue from './getSafeValue';
 import {getCurrentFiberOwnerNameInDevOrNull} from 'react-reconciler/src/ReactCurrentFiber';
 
 let didWarnValDefaultVal = false;
@@ -110,7 +111,7 @@ export function initWrapperState(element: Element, props: Object) {
         children = children[0];
       }
 
-      defaultValue = '' + children;
+      defaultValue = getSafeValue(children);
     }
     if (defaultValue == null) {
       defaultValue = '';
@@ -119,7 +120,9 @@ export function initWrapperState(element: Element, props: Object) {
   }
 
   node._wrapperState = {
-    initialValue: '' + initialValue,
+    initialValue: getSafeValue(
+      props.value != null ? props.value : initialValue,
+    ),
   };
 }
 
@@ -129,7 +132,7 @@ export function updateWrapper(element: Element, props: Object) {
   if (value != null) {
     // Cast `value` to a string to ensure the value is set correctly. While
     // browsers typically do this as necessary, jsdom doesn't.
-    const newValue = '' + value;
+    const newValue = getSafeValue(value);
 
     // To avoid side effects (such as losing text selection), only set value if changed
     if (newValue !== node.value) {
@@ -140,7 +143,7 @@ export function updateWrapper(element: Element, props: Object) {
     }
   }
   if (props.defaultValue != null) {
-    node.defaultValue = props.defaultValue;
+    node.defaultValue = getSafeValue(props.defaultValue);
   }
 }
 

From 635d28865b6809a80535b07b46878eef7c02fd23 Mon Sep 17 00:00:00 2001
From: raunofreiberg <freiberggg@gmail.com>
Date: Fri, 10 Aug 2018 15:47:46 +0300
Subject: [PATCH 03/11] tests: add TODOs for warnings

---
 packages/react-dom/src/__tests__/ReactDOMTextarea-test.js | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/packages/react-dom/src/__tests__/ReactDOMTextarea-test.js b/packages/react-dom/src/__tests__/ReactDOMTextarea-test.js
index 586042a99cf9b..c8caf5f53f6c1 100644
--- a/packages/react-dom/src/__tests__/ReactDOMTextarea-test.js
+++ b/packages/react-dom/src/__tests__/ReactDOMTextarea-test.js
@@ -460,6 +460,7 @@ describe('ReactDOMTextarea', () => {
       ReactDOM.render(<textarea defaultValue={Symbol('foobar')} />, container);
       const node = container.firstChild;
 
+      // TODO: add warnings once defaultValue is compatible for them
       expect(node.value).toBe('');
     });
 
@@ -469,6 +470,7 @@ describe('ReactDOMTextarea', () => {
       ReactDOM.render(<textarea defaultValue={Symbol('foobar')} />, container);
       const node = container.firstChild;
 
+      // TODO: add warnings once defaultValue is compatible for them
       expect(node.value).toBe('foo');
     });
   });
@@ -519,6 +521,7 @@ describe('ReactDOMTextarea', () => {
       ReactDOM.render(<textarea defaultValue={() => {}} />, container);
       const node = container.firstChild;
 
+      // TODO: add warnings once defaultValue is compatible for them
       expect(node.value).toBe('');
     });
 
@@ -528,6 +531,7 @@ describe('ReactDOMTextarea', () => {
       ReactDOM.render(<textarea defaultValue={() => {}} />, container);
       const node = container.firstChild;
 
+      // TODO: add warnings once defaultValue is compatible for them
       expect(node.value).toBe('foo');
     });
   });

From 1c4bded57aee4ca71eb57881d6637f0ea76a98e5 Mon Sep 17 00:00:00 2001
From: raunofreiberg <freiberggg@gmail.com>
Date: Fri, 10 Aug 2018 16:16:56 +0300
Subject: [PATCH 04/11] fix: restore accidentally removed test

---
 .../react-dom/src/__tests__/ReactDOMTextarea-test.js | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/packages/react-dom/src/__tests__/ReactDOMTextarea-test.js b/packages/react-dom/src/__tests__/ReactDOMTextarea-test.js
index c8caf5f53f6c1..8e44d3fddce0f 100644
--- a/packages/react-dom/src/__tests__/ReactDOMTextarea-test.js
+++ b/packages/react-dom/src/__tests__/ReactDOMTextarea-test.js
@@ -202,6 +202,18 @@ describe('ReactDOMTextarea', () => {
     expect(node.value).toBe('0');
   });
 
+  it('should take updates to children in lieu of `defaultValue` for uncontrolled textarea', () => {
+    const container = document.createElement('div');
+
+    const node = ReactDOM.render(<textarea defaultValue="0" />, container);
+
+    expect(node.value).toBe('0');
+
+    ReactDOM.render(<textarea>1</textarea>, container);
+
+    expect(node.value).toBe('0');
+  });
+
   it('should not incur unnecessary DOM mutations', () => {
     const container = document.createElement('div');
     ReactDOM.render(<textarea value="a" onChange={emptyFunction} />, container);

From 05647294433e4972942a5a9efedfed6072d9abe5 Mon Sep 17 00:00:00 2001
From: raunofreiberg <freiberggg@gmail.com>
Date: Fri, 10 Aug 2018 21:39:38 +0300
Subject: [PATCH 05/11] fix: remove redundant logic for initialValue

---
 packages/react-dom/src/client/ReactDOMFiberTextarea.js | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/packages/react-dom/src/client/ReactDOMFiberTextarea.js b/packages/react-dom/src/client/ReactDOMFiberTextarea.js
index 0a59182157a2c..87c3ee520ec3e 100644
--- a/packages/react-dom/src/client/ReactDOMFiberTextarea.js
+++ b/packages/react-dom/src/client/ReactDOMFiberTextarea.js
@@ -120,9 +120,7 @@ export function initWrapperState(element: Element, props: Object) {
   }
 
   node._wrapperState = {
-    initialValue: getSafeValue(
-      props.value != null ? props.value : initialValue,
-    ),
+    initialValue: getSafeValue(initialValue),
   };
 }
 

From 282571c1eed5412b60eb11fa7dd135932a25652b Mon Sep 17 00:00:00 2001
From: raunofreiberg <freiberggg@gmail.com>
Date: Sun, 12 Aug 2018 18:31:29 +0300
Subject: [PATCH 06/11] refactor: integrate SafeValue typings into textarea

---
 .../src/client/ReactDOMFiberInput.js          |  1 -
 .../src/client/ReactDOMFiberTextarea.js       | 21 ++++++++----------
 packages/react-dom/src/client/getSafeValue.js | 22 -------------------
 3 files changed, 9 insertions(+), 35 deletions(-)
 delete mode 100644 packages/react-dom/src/client/getSafeValue.js

diff --git a/packages/react-dom/src/client/ReactDOMFiberInput.js b/packages/react-dom/src/client/ReactDOMFiberInput.js
index 0f15e7e97cd00..51bcf215021c9 100644
--- a/packages/react-dom/src/client/ReactDOMFiberInput.js
+++ b/packages/react-dom/src/client/ReactDOMFiberInput.js
@@ -17,7 +17,6 @@ import {getFiberCurrentPropsFromNode} from './ReactDOMComponentTree';
 import {getToStringValue, toString} from './ToStringValue';
 import ReactControlledValuePropTypes from '../shared/ReactControlledValuePropTypes';
 import * as inputValueTracking from './inputValueTracking';
-import getSafeValue from './getSafeValue';
 
 import type {ToStringValue} from './ToStringValue';
 
diff --git a/packages/react-dom/src/client/ReactDOMFiberTextarea.js b/packages/react-dom/src/client/ReactDOMFiberTextarea.js
index 87c3ee520ec3e..53033d03db326 100644
--- a/packages/react-dom/src/client/ReactDOMFiberTextarea.js
+++ b/packages/react-dom/src/client/ReactDOMFiberTextarea.js
@@ -11,14 +11,15 @@ import invariant from 'shared/invariant';
 import warning from 'shared/warning';
 
 import ReactControlledValuePropTypes from '../shared/ReactControlledValuePropTypes';
-import getSafeValue from './getSafeValue';
 import {getCurrentFiberOwnerNameInDevOrNull} from 'react-reconciler/src/ReactCurrentFiber';
+import {getSafeValue, safeValueToString} from './SafeValue';
+import type {SafeValue} from './SafeValue';
 
 let didWarnValDefaultVal = false;
 
 type TextAreaWithWrapperState = HTMLTextAreaElement & {
   _wrapperState: {
-    initialValue: string,
+    initialValue: SafeValue,
   },
 };
 
@@ -55,7 +56,7 @@ export function getHostProps(element: Element, props: Object) {
     ...props,
     value: undefined,
     defaultValue: undefined,
-    children: '' + node._wrapperState.initialValue,
+    children: safeValueToString(getSafeValue(node._wrapperState.initialValue)),
   };
 
   return hostProps;
@@ -126,22 +127,18 @@ export function initWrapperState(element: Element, props: Object) {
 
 export function updateWrapper(element: Element, props: Object) {
   const node = ((element: any): TextAreaWithWrapperState);
-  const value = props.value;
+  const value = getSafeValue(props.value);
   if (value != null) {
-    // Cast `value` to a string to ensure the value is set correctly. While
-    // browsers typically do this as necessary, jsdom doesn't.
-    const newValue = getSafeValue(value);
-
     // To avoid side effects (such as losing text selection), only set value if changed
-    if (newValue !== node.value) {
-      node.value = newValue;
+    if ((value: any) !== node.value) {
+      node.value = safeValueToString(value);
     }
     if (props.defaultValue == null) {
-      node.defaultValue = newValue;
+      node.defaultValue = safeValueToString(value);
     }
   }
   if (props.defaultValue != null) {
-    node.defaultValue = getSafeValue(props.defaultValue);
+    node.defaultValue = safeValueToString(getSafeValue(props.defaultValue));
   }
 }
 
diff --git a/packages/react-dom/src/client/getSafeValue.js b/packages/react-dom/src/client/getSafeValue.js
deleted file mode 100644
index 71d79739b63e1..0000000000000
--- a/packages/react-dom/src/client/getSafeValue.js
+++ /dev/null
@@ -1,22 +0,0 @@
-/**
- * Copyright (c) 2015-present, Facebook, Inc.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- *
- * @flow
- */
-
-export default function getSafeValue(value: *): * {
-  switch (typeof value) {
-    case 'boolean':
-    case 'number':
-    case 'object':
-    case 'string':
-    case 'undefined':
-      return value;
-    default:
-      // function, symbol are assigned as empty strings
-      return '';
-  }
-}

From 88f40f1ae4b4258a9a97a28fdba637a5093a998f Mon Sep 17 00:00:00 2001
From: Rauno <freiberggg@gmail.com>
Date: Sun, 12 Aug 2018 20:19:06 +0300
Subject: [PATCH 07/11] fix: restore stringified newValue for equality check

---
 packages/react-dom/src/client/ReactDOMFiberTextarea.js | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/packages/react-dom/src/client/ReactDOMFiberTextarea.js b/packages/react-dom/src/client/ReactDOMFiberTextarea.js
index 53033d03db326..333182414703f 100644
--- a/packages/react-dom/src/client/ReactDOMFiberTextarea.js
+++ b/packages/react-dom/src/client/ReactDOMFiberTextarea.js
@@ -129,12 +129,15 @@ export function updateWrapper(element: Element, props: Object) {
   const node = ((element: any): TextAreaWithWrapperState);
   const value = getSafeValue(props.value);
   if (value != null) {
+    // Cast `value` to a string to ensure the value is set correctly. While
+    // browsers typically do this as necessary, jsdom doesn't.
+    const newValue = safeValueToString(value);
     // To avoid side effects (such as losing text selection), only set value if changed
-    if ((value: any) !== node.value) {
-      node.value = safeValueToString(value);
+    if (newValue !== node.value) {
+      node.value = newValue;
     }
     if (props.defaultValue == null) {
-      node.defaultValue = safeValueToString(value);
+      node.defaultValue = newValue;
     }
   }
   if (props.defaultValue != null) {

From 07ab55dc1a3790461c5de0e3ccc4d93e5fbb44db Mon Sep 17 00:00:00 2001
From: Rauno <freiberggg@gmail.com>
Date: Sun, 12 Aug 2018 20:21:58 +0300
Subject: [PATCH 08/11] fix: remove getSafeValue from hostProps

---
 packages/react-dom/src/client/ReactDOMFiberTextarea.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/react-dom/src/client/ReactDOMFiberTextarea.js b/packages/react-dom/src/client/ReactDOMFiberTextarea.js
index 333182414703f..8f751b72759db 100644
--- a/packages/react-dom/src/client/ReactDOMFiberTextarea.js
+++ b/packages/react-dom/src/client/ReactDOMFiberTextarea.js
@@ -56,7 +56,7 @@ export function getHostProps(element: Element, props: Object) {
     ...props,
     value: undefined,
     defaultValue: undefined,
-    children: safeValueToString(getSafeValue(node._wrapperState.initialValue)),
+    children: safeValueToString(node._wrapperState.initialValue),
   };
 
   return hostProps;

From d350db145be6974d69fe3a37fafd47211347a1dc Mon Sep 17 00:00:00 2001
From: raunofreiberg <freiberggg@gmail.com>
Date: Mon, 13 Aug 2018 17:13:10 +0300
Subject: [PATCH 09/11] refactor: SafeValue -> ToStringValue

---
 .../src/client/ReactDOMFiberTextarea.js        | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/packages/react-dom/src/client/ReactDOMFiberTextarea.js b/packages/react-dom/src/client/ReactDOMFiberTextarea.js
index 8f751b72759db..80034caaf2e1c 100644
--- a/packages/react-dom/src/client/ReactDOMFiberTextarea.js
+++ b/packages/react-dom/src/client/ReactDOMFiberTextarea.js
@@ -12,14 +12,14 @@ import warning from 'shared/warning';
 
 import ReactControlledValuePropTypes from '../shared/ReactControlledValuePropTypes';
 import {getCurrentFiberOwnerNameInDevOrNull} from 'react-reconciler/src/ReactCurrentFiber';
-import {getSafeValue, safeValueToString} from './SafeValue';
-import type {SafeValue} from './SafeValue';
+import {getToStringValue, toString} from './ToStringValue';
+import type {ToStringValue} from './ToStringValue';
 
 let didWarnValDefaultVal = false;
 
 type TextAreaWithWrapperState = HTMLTextAreaElement & {
   _wrapperState: {
-    initialValue: SafeValue,
+    initialValue: ToStringValue,
   },
 };
 
@@ -56,7 +56,7 @@ export function getHostProps(element: Element, props: Object) {
     ...props,
     value: undefined,
     defaultValue: undefined,
-    children: safeValueToString(node._wrapperState.initialValue),
+    children: toString(node._wrapperState.initialValue),
   };
 
   return hostProps;
@@ -112,7 +112,7 @@ export function initWrapperState(element: Element, props: Object) {
         children = children[0];
       }
 
-      defaultValue = getSafeValue(children);
+      defaultValue = getToStringValue(children);
     }
     if (defaultValue == null) {
       defaultValue = '';
@@ -121,17 +121,17 @@ export function initWrapperState(element: Element, props: Object) {
   }
 
   node._wrapperState = {
-    initialValue: getSafeValue(initialValue),
+    initialValue: getToStringValue(initialValue),
   };
 }
 
 export function updateWrapper(element: Element, props: Object) {
   const node = ((element: any): TextAreaWithWrapperState);
-  const value = getSafeValue(props.value);
+  const value = getToStringValue(props.value);
   if (value != null) {
     // Cast `value` to a string to ensure the value is set correctly. While
     // browsers typically do this as necessary, jsdom doesn't.
-    const newValue = safeValueToString(value);
+    const newValue = toString(value);
     // To avoid side effects (such as losing text selection), only set value if changed
     if (newValue !== node.value) {
       node.value = newValue;
@@ -141,7 +141,7 @@ export function updateWrapper(element: Element, props: Object) {
     }
   }
   if (props.defaultValue != null) {
-    node.defaultValue = safeValueToString(getSafeValue(props.defaultValue));
+    node.defaultValue = toString(getToStringValue(props.defaultValue));
   }
 }
 

From c3dc409956087fc0374a34885071b5ad9480acf2 Mon Sep 17 00:00:00 2001
From: raunofreiberg <freiberggg@gmail.com>
Date: Mon, 13 Aug 2018 17:20:03 +0300
Subject: [PATCH 10/11] refactor: update TODO comment in test file

---
 packages/react-dom/src/__tests__/ReactDOMTextarea-test.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/packages/react-dom/src/__tests__/ReactDOMTextarea-test.js b/packages/react-dom/src/__tests__/ReactDOMTextarea-test.js
index 8e44d3fddce0f..47c8bf51a0f80 100644
--- a/packages/react-dom/src/__tests__/ReactDOMTextarea-test.js
+++ b/packages/react-dom/src/__tests__/ReactDOMTextarea-test.js
@@ -472,7 +472,7 @@ describe('ReactDOMTextarea', () => {
       ReactDOM.render(<textarea defaultValue={Symbol('foobar')} />, container);
       const node = container.firstChild;
 
-      // TODO: add warnings once defaultValue is compatible for them
+      // TODO: defaultValue is a reserved prop and is not validated. Check warnings when they are.
       expect(node.value).toBe('');
     });
 
@@ -482,7 +482,7 @@ describe('ReactDOMTextarea', () => {
       ReactDOM.render(<textarea defaultValue={Symbol('foobar')} />, container);
       const node = container.firstChild;
 
-      // TODO: add warnings once defaultValue is compatible for them
+      // TODO: defaultValue is a reserved prop and is not validated. Check warnings when they are.
       expect(node.value).toBe('foo');
     });
   });
@@ -533,7 +533,7 @@ describe('ReactDOMTextarea', () => {
       ReactDOM.render(<textarea defaultValue={() => {}} />, container);
       const node = container.firstChild;
 
-      // TODO: add warnings once defaultValue is compatible for them
+      // TODO: defaultValue is a reserved prop and is not validated. Check warnings when they are.
       expect(node.value).toBe('');
     });
 
@@ -543,7 +543,7 @@ describe('ReactDOMTextarea', () => {
       ReactDOM.render(<textarea defaultValue={() => {}} />, container);
       const node = container.firstChild;
 
-      // TODO: add warnings once defaultValue is compatible for them
+      // TODO: defaultValue is a reserved prop and is not validated. Check warnings when they are.
       expect(node.value).toBe('foo');
     });
   });

From 1ff2275289f9cb1b230dca7218c3a4ed6828c9ee Mon Sep 17 00:00:00 2001
From: raunofreiberg <freiberggg@gmail.com>
Date: Tue, 14 Aug 2018 12:33:29 +0300
Subject: [PATCH 11/11] refactor: no need to convert children to ToStringValue

---
 packages/react-dom/src/client/ReactDOMFiberTextarea.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/react-dom/src/client/ReactDOMFiberTextarea.js b/packages/react-dom/src/client/ReactDOMFiberTextarea.js
index 80034caaf2e1c..9fb832dea67b2 100644
--- a/packages/react-dom/src/client/ReactDOMFiberTextarea.js
+++ b/packages/react-dom/src/client/ReactDOMFiberTextarea.js
@@ -112,7 +112,7 @@ export function initWrapperState(element: Element, props: Object) {
         children = children[0];
       }
 
-      defaultValue = getToStringValue(children);
+      defaultValue = children;
     }
     if (defaultValue == null) {
       defaultValue = '';