Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose persistent reconciler to custom renderers #12156

Merged
merged 1 commit into from
Feb 5, 2018

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Feb 5, 2018

Ideally we'd write a test for this via react-noop but that requires some rewiring so I didn't bother. It's even more experimental than the main react-reconciler anyway. We can fix this later.

Test plan:

var r = require('react-reconciler/persistent');
var rend = r({
  now() { return Date.now() },
  persistence: {},
  scheduleDeferredCallback() {}
});

var c = rend.createContainer({}, true, false)
rend.updateContainer('lol', c, null);

This was enough to smoke-test it and verify the flag gets set (if you remove /persistent it crashes). There might be other issues but I think it's good for starters.

@gaearon
Copy link
Collaborator Author

gaearon commented Feb 5, 2018

cc @kenwheeler that's the thing Andrew was talking about

@acdlite acdlite mentioned this pull request Feb 5, 2018
28 tasks
@iamdustan
Copy link
Contributor

haha. That test plan is gold.

@gaearon gaearon merged commit f828ca4 into facebook:master Feb 5, 2018
This was referenced Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants