Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【iOS】Fix timer background state when App is launched from background #39347

Closed
wants to merge 5 commits into from
Closed

【iOS】Fix timer background state when App is launched from background #39347

wants to merge 5 commits into from

Conversation

zhongwuzw
Copy link
Contributor

Summary:

Fixes #38711

Changelog:

[IOS] [FIXED] - Fix timer background state when App is launched from background

Test Plan:

Please see #38711

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Sep 8, 2023
@zhongwuzw zhongwuzw mentioned this pull request Sep 8, 2023
Closed
@dmytrorykun
Copy link
Contributor

@zhongwuzw CircleCI complains about failing unit tests here

react-native/packages/rn-tester/RNTesterIntegrationTests/RCTLoggingTests.m

Line 77 in 016e4af

- (void)testLogging

Could you please take a look?

@zhongwuzw
Copy link
Contributor Author

@dmytrorykun Thanks for review, test failed has fixed.

@facebook-github-bot
Copy link
Contributor

@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

cipolleschi
cipolleschi requested changes Sep 9, 2023
View reviewed changes
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! Thank you for the time invested in fixing this issue.
There are two code changes that we need to apply in order to actually land this.
Could you take care of changing the code accordingly? 🙏

packages/react-native/React/CoreModules/RCTTiming.mm Outdated Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

cipolleschi
cipolleschi approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you so much for this.

@facebook-github-bot
Copy link
Contributor

@dmytrorykun merged this pull request in a4ea737.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 11, 2023
Titozzz pushed a commit that referenced this pull request Sep 11, 2023
@zhongwuzw @Titozzz
【iOS】Fix timer background state when App is launched from background (#…
f6fd6b8 
…39347)

Summary:
Fixes #38711

## Changelog:

[IOS] [FIXED] - Fix timer background state when App is launched from background

Pull Request resolved: #39347

Test Plan: Please see #38711

Reviewed By: cipolleschi

Differential Revision: D49101979

Pulled By: dmytrorykun

fbshipit-source-id: e25b182539f39e4465fa40e51288d88c68967b31
@cipolleschi cipolleschi mentioned this pull request Sep 21, 2023
Merged
@cipolleschi cipolleschi mentioned this pull request Oct 12, 2023
Merged
@NOUIY NOUIY mentioned this pull request Oct 16, 2023
Open
@cipolleschi cipolleschi mentioned this pull request Nov 1, 2023
Merged
@NOUIY NOUIY mentioned this pull request Nov 4, 2023
Open
@NOUIY NOUIY mentioned this pull request Dec 8, 2023
Open
@cipolleschi cipolleschi mentioned this pull request Dec 27, 2023
Merged
@cipolleschi cipolleschi mentioned this pull request Jan 4, 2024
Merged
This was referenced Jan 8, 2024
Merged
Merged
Closed
This was referenced Feb 28, 2024
Merged
Merged
Merged
@cipolleschi cipolleschi mentioned this pull request Jun 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikelehen mikelehen mikelehen left review comments

@cipolleschi cipolleschi cipolleschi approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[iOS] JS Timers (setTimeout) don't fire when app is launched in background
5 participants
@zhongwuzw @dmytrorykun @facebook-github-bot @mikelehen @cipolleschi