Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send extra onChangeText even wnen instantianting multiline TextView #36930

Closed
wants to merge 1 commit into from

Commits on Apr 18, 2023

  1. Do not send extra onChangeText even wnen instantianting multiline Tex…

    …tView (facebook#36930)
    
    Summary:
    Pull Request resolved: facebook#36930
    
    This diff fixes facebook#36494
    
    Now this code matches its [Fabric counterpart](facebook@7b48899).
    
    There is also one extra check that `_lastStringStateWasUpdatedWith != nil`. With that in place we don't send extra `onChangeText` event when `attributedText` is assigned for the first time on TextView construction.
    
    Changelog: [IOS][Fixed] - Do not send extra onChangeText even wnen instantianting multiline TextView
    
    Reviewed By: sammy-SC
    
    Differential Revision: D45049135
    
    fbshipit-source-id: 3351b9b62fca5e8722c8da08f2c081b857164458
    dmytrorykun authored and facebook-github-bot committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    b402552 View commit details
    Browse the repository at this point in the history