Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode builds have over 450 warnings #19628

Closed
5 tasks done
randyhill opened this issue Jun 8, 2018 · 11 comments
Closed
5 tasks done

Xcode builds have over 450 warnings #19628

randyhill opened this issue Jun 8, 2018 · 11 comments
Labels
Platform: iOS iOS applications. Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@randyhill
Copy link

randyhill commented Jun 8, 2018

Environment

Environment:
OS: macOS High Sierra 10.13.4
Node: 10.0.0
Yarn: 1.5.1
npm: 5.6.0
Watchman: 4.9.0
Xcode: Xcode 9.4 Build version 9F1027a
Android Studio: Not Found

Packages: (wanted => installed)
react: 16.3.0-alpha.2 => 16.3.0-alpha.2
react-native: ^0.55.3 => 0.55.3

Description

When building iOS app from react native project we get 451 compile warnings, all of which appear to be in the React Native objective C code.

Steps to Reproduce

Build a react native project in XCode.

Expected Behavior

There will be zero warnings. Warnings are a sign of poor coding practices, and even though many are just unused parameters, they can obscure very important warnings. Our own native code has warnings obscured by this long list of unfixed coding errors. And it makes finding compile errors in our code more difficult and tedious.

Actual Behavior

A mass of unfinished technical debt spewed across hundreds of lines of my build output.

@hramos hramos added the Platform: iOS iOS applications. label Jun 9, 2018
@hramos
Copy link
Contributor

hramos commented Jun 9, 2018

Here's a PR that was opened recently to address these warnings in Xcode: #19574

Looking for more PRs to help in this regards, let us know if you want to take a stab at this!

@hramos hramos changed the title XCode builds have over 450 warnings Xcode builds have over 450 warnings Jun 9, 2018
@randyhill
Copy link
Author

It's a reasonable request. I'll see if I can find time to contribute and let you know.

@libersolis-dev
Copy link

This has been a nightmare to deal with. I've tried so many things and spent an incredible amount of time trying to push a new release to the app store, with no success. I'm looking for any solution to get this release pushed.

@hramos
Copy link
Contributor

hramos commented Jun 10, 2018

As far as I am aware, these are standard Xcode warnings that show up with each Xcode release, e.g. they're recommendations for how your Xcode project settings should be updated. It only affects the base template used when you create a new project, and you should be able to deal with the same way you would with any regular Xcode project.

@rajivshah3
Copy link
Contributor

@mannyhagman are you talking about errors (exclamation point inside a red octagon/stop sign)?

Warnings such as the one below shouldn't be causing the build to fail:
image

@rajivshah3
Copy link
Contributor

rajivshah3 commented Jun 11, 2018

@randyhill as a workaround, you can use the search box to filter the issues for your own project and exclude the React warnings like this:

image

@hramos
Copy link
Contributor

hramos commented Jun 11, 2018

We just released a new version, 0.56.0-rc, that should take care of a good number of these. Can you take a look?

@mattijsf
Copy link
Contributor

Good to know that there is work done to reduce the amount of warnings!

I've made this package to silence some (if not all) of these warnings: https://github.com/mattijsf/react-native-inhibit-warnings

Disclaimer: It's a actually terrible idea to use it!

@stale
Copy link

stale bot commented Sep 11, 2018

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Sep 11, 2018
@stale
Copy link

stale bot commented Sep 18, 2018

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Sep 18, 2018
@facebook facebook locked as resolved and limited conversation to collaborators Sep 19, 2018
@hramos
Copy link
Contributor

hramos commented Dec 11, 2018

Tracking all remaining warnings in #22609

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Platform: iOS iOS applications. Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

5 participants