{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":16211818,"defaultBranch":"main","name":"mcrouter","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-01-24T17:42:42.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1726499059.0","currentOid":""},"activityList":{"items":[{"before":"0b2cd13fe1eca2afa0d8ae91e9d8e8b0ef8dd9fe","after":"e7c6c79b8aa11754b9b1d69e1bb20cae70801db9","ref":"refs/heads/main","pushedAt":"2024-09-16T21:51:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add RouterInfo include and dependency to ClientTool\n\nSummary: This is needed for the stacked diffs which changes RoutingGroups and requires for the correct RoutingGroups.h files to be included in the tool. RouterInfo will always include the correct RoutingGroups.h\n\nReviewed By: disylh\n\nDifferential Revision: D62471587\n\nfbshipit-source-id: f586fd222f4579add33b4d1a5997fcd460de1b6c","shortMessageHtmlLink":"Add RouterInfo include and dependency to ClientTool"}},{"before":"9beaf1850e3df56cf5457c80330d7a33cf6eff59","after":"0b2cd13fe1eca2afa0d8ae91e9d8e8b0ef8dd9fe","ref":"refs/heads/main","pushedAt":"2024-09-16T21:13:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Update injection service to populate usecaseId\n\nSummary:\nAs described in D62582055, update injection service to set usecase ID in delete request for DL.\n\nD60796664 parse usecase ID for strict namespace DT. The diff invoke the same parsing function. Usecase ID can also be set from PrefixUsecaseRoute in Mcrouter, the diff add support to obtain from recording context.\n\nReviewed By: stuclar\n\nDifferential Revision: D62582054\n\nfbshipit-source-id: 6b083e5be7152b1fbaf40b279eeb44ac8044097a","shortMessageHtmlLink":"Update injection service to populate usecaseId"}},{"before":"64334f9c791eb20ab27364964106b8271ea39977","after":"9beaf1850e3df56cf5457c80330d7a33cf6eff59","ref":"refs/heads/main","pushedAt":"2024-09-16T14:28:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Refactor uses of setClientCertificate to setClientCertManager\n\nSummary: use the new setClientCertManager method instead of the deprecated setClientCertificate method and remove it from FizzClientContext.h\n\nReviewed By: zxjtan\n\nDifferential Revision: D62404702\n\nfbshipit-source-id: 936c19c31499558043e50027875143edebb4539c","shortMessageHtmlLink":"Refactor uses of setClientCertificate to setClientCertManager"}},{"before":"5fd3079808d5cb856a2983d8dae3d31b7eb067d4","after":"64334f9c791eb20ab27364964106b8271ea39977","ref":"refs/heads/main","pushedAt":"2024-09-12T23:05:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Log usecase Id in mcrouter scuba\n\nSummary: As title, logging usecase id in mcrouter_requests scuba\n\nReviewed By: alikhtarov\n\nDifferential Revision: D60121565\n\nfbshipit-source-id: d68b1fbf55a89f90fe8180eab2a989578ad94be6","shortMessageHtmlLink":"Log usecase Id in mcrouter scuba"}},{"before":"87158a15c3698c0a769a2d2ff2fca289ed776ed9","after":"5fd3079808d5cb856a2983d8dae3d31b7eb067d4","ref":"refs/heads/main","pushedAt":"2024-09-12T22:35:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"migrate from untagged array-range dynamic ctor (assorted)\n\nReviewed By: Orvid\n\nDifferential Revision: D62553013\n\nfbshipit-source-id: 14d9ffcd3527e80ccf16e7ec311bece4334fe174","shortMessageHtmlLink":"migrate from untagged array-range dynamic ctor (assorted)"}},{"before":"1f8a445c7ce2b8262cc990aae3649ab35e26cadd","after":"87158a15c3698c0a769a2d2ff2fca289ed776ed9","ref":"refs/heads/main","pushedAt":"2024-09-12T21:17:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add ClientIdentifier in RequestCommon\n\nSummary:\nWhat?\n- ClientIdentifier = Hash string of primary (non-host) tls client identities\n- **This diff** adds ClientIdentifier field in RequestCommon which will be extracted in codegen (next diffs) to pass the ClientIdentifier in header to memcache server\n- This change is ONLY for proxies and will be executed during shadow testing ONLY\n\nWHY?\n- SAP and uCache are working on securing look-aside cache called \"Key Client Binding\" feature where we bind keys in uCache with ClientIdentities. This ensures that cached data is restricted to the specific client who has access to the backed service.\n\n- Design doc: https://fburl.com/gdoc/psjwp58j\n\nReviewed By: lenar-f\n\nDifferential Revision: D62452894\n\nfbshipit-source-id: 4dfb17a4b3d3389b610879304ce1c304838aa034","shortMessageHtmlLink":"Add ClientIdentifier in RequestCommon"}},{"before":"d06c77df9e772f282edfba240436ac7120c6e212","after":"1f8a445c7ce2b8262cc990aae3649ab35e26cadd","ref":"refs/heads/main","pushedAt":"2024-09-12T00:47:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"RoutingGroup bugfixes\n\nSummary:\n- In the first case, we're applying OtherThanT to a Reply type instead of Request\n- In the second case, we're assuming `GetLike<RequestFromReplyType<Reply, RequestReplyPairs>>::value` is always defined, including for types which are not included in RequestReplyPairs (and defaults to false)\n\nReviewed By: disylh\n\nDifferential Revision: D62397115\n\nfbshipit-source-id: 6787ec130284751d5a86120dd036d01944beed29","shortMessageHtmlLink":"RoutingGroup bugfixes"}},{"before":"d80da5d817481ad64530a2f9a01612cf1a9ce879","after":"d06c77df9e772f282edfba240436ac7120c6e212","ref":"refs/heads/main","pushedAt":"2024-09-03T22:14:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"when distributing deletes, always route local RPC\n\nSummary:\nIn this diff we change how delete distribution works:\n* Distribution happens asynchronously (except spooling)\n* Sync path is local region RPC\n* In case of directed cross-region requests just return default reply\n\ni.e., the Distribution Layer is responsible for:\n* delivering async requests\n* distributing cross-regional requests\n\nReviewed By: stuclar\n\nDifferential Revision: D57145745\n\nfbshipit-source-id: b19cf6cce1b9a2cdb531df975030b9e8481fc517","shortMessageHtmlLink":"when distributing deletes, always route local RPC"}},{"before":"53dd319ad7f33c03e45a504339bbf6aba21fa24c","after":"d80da5d817481ad64530a2f9a01612cf1a9ce879","ref":"refs/heads/main","pushedAt":"2024-09-03T21:50:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Implement additional fanout for SRRoute\n\nSummary: as title\n\nReviewed By: disylh\n\nDifferential Revision: D61860873\n\nfbshipit-source-id: f78632c33c1919aeef4fea66b97ce16fdff0fabe","shortMessageHtmlLink":"Implement additional fanout for SRRoute"}},{"before":"d25381fb815115aa925e0514726f14f3a89eaf17","after":"53dd319ad7f33c03e45a504339bbf6aba21fa24c","ref":"refs/heads/main","pushedAt":"2024-08-30T18:54:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"DistributionRoute changes to accommodate SET distribution\n\nSummary: Distribution operation is async, the local RPC request is sync.\n\nReviewed By: stuclar\n\nDifferential Revision: D56957380\n\nfbshipit-source-id: 339188c0302bdf6ae04ad8b63f4800f983f3f7c2","shortMessageHtmlLink":"DistributionRoute changes to accommodate SET distribution"}},{"before":"1986c8592d426f580a00638ae319948a7cd6ad1f","after":"d25381fb815115aa925e0514726f14f3a89eaf17","ref":"refs/heads/main","pushedAt":"2024-08-30T00:46:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fix broken test, pass default region filter in DestinationRoute for spool\n\nSummary: Details: https://www.internalfb.com/intern/test/844425091482984\n\nReviewed By: disylh\n\nDifferential Revision: D61998680\n\nfbshipit-source-id: b1a6c89ce3db9cc34c0de4887f3f9b3bb4735bb5","shortMessageHtmlLink":"fix broken test, pass default region filter in DestinationRoute for s…"}},{"before":"05ec9607d4aa48828141460e5b3b4ea808ad20c2","after":"1986c8592d426f580a00638ae319948a7cd6ad1f","ref":"refs/heads/main","pushedAt":"2024-08-29T17:11:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"RootRoute logic to distribute SET requests\n\nSummary: Now McSetRequest type can be distributed as well.\n\nReviewed By: stuclar\n\nDifferential Revision: D56891076\n\nfbshipit-source-id: a633b3df0aec86cd486a680a95f26088a767384b","shortMessageHtmlLink":"RootRoute logic to distribute SET requests"}},{"before":"2501da895d27e574d072a4bc322594d0aefb6aec","after":"05ec9607d4aa48828141460e5b3b4ea808ad20c2","ref":"refs/heads/main","pushedAt":"2024-08-29T13:28:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"add distributeAxonProxy fn to distribute SET reqs\n\nSummary:\n* renaming McSpoolUtils to McDistributionUtils\n* add `distirbuteSetRequest` fn to distribute SETs\n* add two new key-value pairs: `DistributionOperation` - to distinguish between SETs and DELETEs, and `DistributionType` - async or distribution.\n\nReviewed By: stuclar\n\nDifferential Revision: D56890418\n\nfbshipit-source-id: 3c54f946a1a9b8b3582634e067473b0502dd3bcb","shortMessageHtmlLink":"add distributeAxonProxy fn to distribute SET reqs"}},{"before":"b4818bffca49c12ea86b36d318dedbf3da5cdd08","after":"2501da895d27e574d072a4bc322594d0aefb6aec","ref":"refs/heads/main","pushedAt":"2024-08-26T21:21:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"add key client binding flag to request\n\nSummary: We pass the flag to enable key-client binding to the server via the request flags.\n\nReviewed By: disylh\n\nDifferential Revision: D61807959\n\nfbshipit-source-id: 0ad9ce0ff18ae3fdf50ce9b26b258323c97cd5ae","shortMessageHtmlLink":"add key client binding flag to request"}},{"before":"7f5c6913b6a9b654d5ddcf99afa2bd2906619067","after":"b4818bffca49c12ea86b36d318dedbf3da5cdd08","ref":"refs/heads/main","pushedAt":"2024-08-23T17:34:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add option to wrap srroute with refill route\n\nSummary: as title\n\nReviewed By: disylh, stuclar\n\nDifferential Revision: D61394564\n\nfbshipit-source-id: 3c9d95a47667a532b4a262b32c119ba85e2adb2c","shortMessageHtmlLink":"Add option to wrap srroute with refill route"}},{"before":"17d4965d632357a6d980a0f26409dd1328cbeda8","after":"7f5c6913b6a9b654d5ddcf99afa2bd2906619067","ref":"refs/heads/main","pushedAt":"2024-08-23T17:00:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add a constexpr var to indicate whether McRefill is enabled for a Router\n\nSummary: as title\n\nReviewed By: disylh\n\nDifferential Revision: D61503306\n\nfbshipit-source-id: edd74112c23088fa512afd36493cb438a23a2f83","shortMessageHtmlLink":"Add a constexpr var to indicate whether McRefill is enabled for a Router"}},{"before":"cb3aa5d40e09350e9caa8de711214184f6fd5091","after":"17d4965d632357a6d980a0f26409dd1328cbeda8","ref":"refs/heads/main","pushedAt":"2024-08-21T23:31:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"refactor m*\n\nReviewed By: mofa28\n\nDifferential Revision: D61433569\n\nfbshipit-source-id: 670b1d6c48f3373509e508b8a83a7dfdcc6fbdd0","shortMessageHtmlLink":"refactor m*"}},{"before":"cbe7838070ef0c322d0d1dc363a41ed3cf09f540","after":"cb3aa5d40e09350e9caa8de711214184f6fd5091","ref":"refs/heads/main","pushedAt":"2024-08-19T23:09:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix processing time test\n\nSummary:\nConvert the stat to int before comparison.\n\nCurrent test is failing https://www.internalfb.com/sandcastle/workflow/4134304457930018223, it's weird that the diff checks did not report this.\n\nReviewed By: disylh\n\nDifferential Revision: D61482520\n\nfbshipit-source-id: 15e88a50487bc0f9e5a8d5c496e032263b499ed5","shortMessageHtmlLink":"Fix processing time test"}},{"before":"0a389262239061daf86d325e76e1a2e78ab031ad","after":"cbe7838070ef0c322d0d1dc363a41ed3cf09f540","ref":"refs/heads/main","pushedAt":"2024-08-16T22:45:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add processing_time_us to ODS stats\n\nSummary: as title\n\nReviewed By: disylh\n\nDifferential Revision: D61135811\n\nfbshipit-source-id: f558d1e3ba2f5f819856a035388742e2cf002577","shortMessageHtmlLink":"Add processing_time_us to ODS stats"}},{"before":"980b7ecad55ec69c42ead20f92ba1522e28c094b","after":"0a389262239061daf86d325e76e1a2e78ab031ad","ref":"refs/heads/main","pushedAt":"2024-08-16T20:40:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add McRefillRoute to Ucache protocol\n\nSummary: As above\n\nReviewed By: disylh\n\nDifferential Revision: D61401868\n\nfbshipit-source-id: 3cee5825991e9fb9633c7f8dcded474364fc1885","shortMessageHtmlLink":"Add McRefillRoute to Ucache protocol"}},{"before":"39264f9dc478adbaace6076d7a63cb8414ead6b7","after":"980b7ecad55ec69c42ead20f92ba1522e28c094b","ref":"refs/heads/main","pushedAt":"2024-08-09T07:15:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"migrate from TAsyncSSLSocket\n\nSummary: `apache::thrift::async::TAsyncSSLSocket` is now just a derived-class wrapper around `folly::AsyncSSLSocket`.\n\nReviewed By: jmswen\n\nDifferential Revision: D60981967\n\nfbshipit-source-id: 8de104555d4049c3b590f99871e857faf19407aa","shortMessageHtmlLink":"migrate from TAsyncSSLSocket"}},{"before":"40d5a99bf40ec6569bd82e3a289a4442f2643a86","after":"39264f9dc478adbaace6076d7a63cb8414ead6b7","ref":"refs/heads/main","pushedAt":"2024-07-30T22:26:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Move RateLimitedLogger to ucache//\n\nSummary:\nMove McRateLimitedLogger and McConnectionLoggerBase to ucache dir and rename.\nResolve build failures.\n\nReviewed By: stuclar\n\nDifferential Revision: D60397635\n\nfbshipit-source-id: 51537466989c89cd9035843f5d428f2a3d26bc62","shortMessageHtmlLink":"Move RateLimitedLogger to ucache//"}},{"before":"c18055dfd24b3941136b1292850cc925b2358c78","after":"40d5a99bf40ec6569bd82e3a289a4442f2643a86","ref":"refs/heads/main","pushedAt":"2024-07-29T16:34:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Migrate dynamic-cast from TAsyncSSLSocket\n\nSummary: [Mcrouter] Migrate `dynamic_cast`s from `TAsyncSSLSocket` to `folly::AsyncSSLSocket`.\n\nReviewed By: Gownta\n\nDifferential Revision: D22118708\n\nfbshipit-source-id: 8e68ab24df7d26703d253c478999b6741134cd51","shortMessageHtmlLink":"Migrate dynamic-cast from TAsyncSSLSocket"}},{"before":"805351f9a55cde40574f4994abba8ae3a18d3ef3","after":"c18055dfd24b3941136b1292850cc925b2358c78","ref":"refs/heads/main","pushedAt":"2024-07-25T18:24:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Make RIM compile within memcache\n\nSummary:\nIn this approach, we create a weakly defined symbol in TargetHooks.cpp that is defined in the mcrouter-core target and conditionally checked and invoked in the gen utils visitor.\n\nThis approach minimizes the amount of changes we want to make as opposed to previous approaches (most of which required making changes to hundreds of target files).\n\nHere we do a few things to make this work:\n1. In rim's stats.cpp TARGET, we have to change the odsl library to use the \"via_mcrouter\" flavor of those targets. autodeps wants to change it back, but that will immediately trigger circular dependencies. For good measure I added, autodeps-skip nocodemods to that target.\n\n2. stuclar taught me about nm and how I can dump the symbols that are compiled in the different modes (dev/opt). I dumped the symbols when building mcrouter_core in both dev and opt mode and I see that gRIMReport is NOT a weak symbol, which IIUC is what we desire.\n\n\tP1430729979, P1430693327 have the full pastes.\n\nopt mode:\n> 0000000000000000 W _ZN8facebook8memcache8mcrouter10gRIMReportERKSt6vectorINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESaIS8_EERKSt13unordered_mapIS8_mSt4hashIS8_ESt8equal_toIS8_ESaISt4pairIKS8_mEEE\n> 0000000000000000 b _ZZN8facebook8memcache8mcrouter10gRIMReportERKSt6vectorINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESaIS8_EERKSt13unordered_mapIS8_mSt4hashIS8_ESt8equal_toIS8_ESaISt4pairIKS8_mEEEE14LOGGING_helper\n\ndev mode:\n> 00000000002055f0 W _ZN8facebook8memcache8mcrouter10gRIMReportERKSt6vectorINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESaIS8_EERKSt13unordered_mapIS8_mSt4hashIS8_ESt8equal_toIS8_ESaISt4pairIKS8_mEEE\n> _ZZN8facebook8memcache8mcrouter10gRIMReportERKSt6vectorINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESaIS8_EERKSt13unordered_mapIS8_mSt4hashIS8_ESt8equal_toIS8_ESaISt4pairIKS8_mEEEE14LOGGING_helper\n\nEdit on Version 6:\n1. I've extracted productId and plumbed it to RIM.\n2. Swayze Test: https://www.internalfb.com/intern/hhvm/automator/workflows/134338/\n\nAnother Swayze Test (with CD_MEMCACHE_ATTRIBUTION used):\nhttps://www.internalfb.com/intern/hhvm/automator/workflows/140328/\n\nReviewed By: stuclar\n\nDifferential Revision: D57884193\n\nfbshipit-source-id: 77f67f14b2db93018b668411a9cdc40c043ae4cf","shortMessageHtmlLink":"Make RIM compile within memcache"}},{"before":"34eb62ef403ce6619df7a527c5906ffbbb41f4ea","after":"805351f9a55cde40574f4994abba8ae3a18d3ef3","ref":"refs/heads/main","pushedAt":"2024-07-25T14:36:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Set -Wno-deprecated-declarations for the OSS build (#446)\n\nSummary:\nBuilding mcrouter currently generates a high volume of deprecation warnings from generated thrift code and from OpenSSL-related deprecations in upstream folly. We already try to set `-Wno-deprecated`, but in modern GCC and clang `-Wno-deprecated-declarations` is needed to silence these warnings instead.\n\nPull Request resolved: https://github.com/facebook/mcrouter/pull/446\n\nReviewed By: djvaporize\n\nDifferential Revision: D59706029\n\nPulled By: stuclar\n\nfbshipit-source-id: b2751c59f53a58d5f765e958bdac3229e3a81dc2","shortMessageHtmlLink":"Set -Wno-deprecated-declarations for the OSS build (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2362920685\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/mcrouter/issues/446\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/mcrouter/pull/446/hovercard\" href=\"https://github.com/facebook/mcrouter/pull/446\">#446</a>)"}},{"before":"984106a1c961b948151abb329ded3a9891993dba","after":"34eb62ef403ce6619df7a527c5906ffbbb41f4ea","ref":"refs/heads/main","pushedAt":"2024-07-25T14:32:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix OSS build (#445)\n\nSummary:\nmcrouter currently does not compile, since the build system is out of sync with recent changes.\n\nDue to the use of `std::span` introduced in\n9a24a4ee3985aa86de726c1e3259eea416d3970c, the project now requires C++20 to build. Update the `-std` flag accordingly, since the existing C++17 requirement was also introduced without much fanfare in 3181213fb2f314db6619d0d5b21e3e53804bc3a1 following a similar change.\n\nAlso update Automake files to reflect some newly added project files, and link against `serverdbginfo` and `runtime` from fbthrift, since they are now required.\n\nPull Request resolved: https://github.com/facebook/mcrouter/pull/445\n\nReviewed By: djvaporize\n\nDifferential Revision: D59706014\n\nPulled By: stuclar\n\nfbshipit-source-id: 096bad533a9028e9188d60b9aab2bd4b7e383255","shortMessageHtmlLink":"Fix OSS build (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2362635012\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/mcrouter/issues/445\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/mcrouter/pull/445/hovercard\" href=\"https://github.com/facebook/mcrouter/pull/445\">#445</a>)"}},{"before":"1e1046cdc4672f91f60e9a698c7daa45ee176bb3","after":"984106a1c961b948151abb329ded3a9891993dba","ref":"refs/heads/main","pushedAt":"2024-07-17T20:04:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove routing hint (tech debt)\n\nSummary:\nThis was an optimization we introduced for Memcache back in 2021. The idea was to pass the host returned by `getConsistentHashHost()` back to the routing layer (SR) as a \"routing hint\". SR could then avoid performing host selection again.\n\nUnfortunately this optimization did not play well with failovers, and we were forced to disable it almost immediately. It was quickly forgotten and became tech debt.\n\nI don't think there is any value in trying to rescue this optimization. The cost (in terms of engineering hours and code complexity) is probably not worth any potential gains in performance, if any. Today SR uses a dedicated uCache route handle tree, which includes a streamlined connection pool implementation, so any gains from a routing hint would be minimal or nil.\n\nReviewed By: stuclar\n\nDifferential Revision:\nD56376007\n\nPrivacy Context Container: L1225223\n\nfbshipit-source-id: 45ed61a4bf255c14368d44076aa71f01d8d6d9ed","shortMessageHtmlLink":"Remove routing hint (tech debt)"}},{"before":"730b9c858fcc083850a2f9540287a112c7e62f26","after":"1e1046cdc4672f91f60e9a698c7daa45ee176bb3","ref":"refs/heads/main","pushedAt":"2024-07-12T21:33:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add CarbonResultInvalidRequest thrift exception\n\nSummary: Add CarbonResultInvalidRequest thrift exception. This exception is for invalid request type of errors and is not retryable. This exception is used by UcMultiGet/UcMultiFill added in D54469882. Will let UcMultiGet/UcMultiFill actually raise this exception after it is rolled out to clients.\n\nReviewed By: stuclar\n\nDifferential Revision: D59596456\n\nfbshipit-source-id: a43a38e9bf5e9729a260dab3da0964eda06363de","shortMessageHtmlLink":"Add CarbonResultInvalidRequest thrift exception"}},{"before":"3befde1991d151062a6fd070c03b0139dcf30bb3","after":"730b9c858fcc083850a2f9540287a112c7e62f26","ref":"refs/heads/main","pushedAt":"2024-07-11T23:18:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix crash in additional_fanout when calling traverse\n\nSummary: As above\n\nReviewed By: alikhtarov\n\nDifferential Revision: D59609681\n\nfbshipit-source-id: 6b4b1f942957451fe3f6e062a0410327bb3ee139","shortMessageHtmlLink":"Fix crash in additional_fanout when calling traverse"}},{"before":"1a2a4a717d9e0d8f1f2b67cff04db267f5f9581f","after":"3befde1991d151062a6fd070c03b0139dcf30bb3","ref":"refs/heads/main","pushedAt":"2024-07-09T02:37:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Make SRRoute initialization not crashed even SR is not linked\n\nSummary: Mcrouter crashed in S430813 due to SR is not linked and config is not gated by service_router_capable. The diff make it throw error instead of crash\n\nReviewed By: stuclar, vrishal\n\nDifferential Revision: D51049080\n\nfbshipit-source-id: 1e6388f84d5013fe023d270e53fc2c62b1e13e2f","shortMessageHtmlLink":"Make SRRoute initialization not crashed even SR is not linked"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xNlQyMTo1MTo1NS4wMDAwMDBazwAAAAS36JIF","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xNlQyMTo1MTo1NS4wMDAwMDBazwAAAAS36JIF","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wNy0wOVQwMjozNzowMy4wMDAwMDBazwAAAAR6MDg4"}},"title":"Activity · facebook/mcrouter"}