Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: --only-changed should include staged files #9799

Merged
merged 2 commits into from
Apr 12, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Apr 11, 2020

Summary

I don't think it makes sense to exclude them.

Test plan

Assertion added to existing test.

@@ -50,36 +50,45 @@ const adapter: SCMAdapter = {
),
cwd,
);
} else if (changedSince) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore whitespace

Copy link
Contributor

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree 👍 the concept should be comparing working directory to HEAD (onlyChanged), or HEAD~ (changedFilesWithAncestor (terrible option name)) or a custom ref (changedSince)

@SimenB SimenB merged commit 0924baf into jestjs:master Apr 12, 2020
@SimenB SimenB deleted the only-changed-staged branch April 12, 2020 15:46
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants