Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fs watcher EMFILE error. #8258

Merged
merged 8 commits into from
Apr 2, 2019

Conversation

scotthovestadt
Copy link
Contributor

Summary

Resolves #8088 by vendoring FSEvents.

Ideally in the long-term this can be removed with the next release of fsevents. See @SimenB's comment here: #8088 (comment)

Changes to FSEvents when brought over from sane:

  • Added type safety
  • Converted Object _tracked to Set for perf.

Test plan

  • Works locally.
  • Tests pass.
  • Was previously used code, so was previously well tested in the wild.

Additional sanity checks appreciated.

"fb-watchman": "^2.0.0",
"graceful-fs": "^4.1.15",
"invariant": "^2.2.4",
"jest-serializer": "^24.4.0",
"jest-util": "^24.6.0",
"jest-worker": "^24.6.0",
"micromatch": "^3.1.10",
"sane": "^4.0.3"
"sane": "^4.0.3",
"walker": "^1.0.7"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uses same dependency as already required by sane, just adding explicitly since we rely on it now too.

@@ -11,22 +11,29 @@
"types": "build/index.d.ts",
"dependencies": {
"@jest/types": "^24.6.0",
"anymatch": "^2.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uses same dependency as already required by sane, just adding explicitly since we rely on it now too.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changelog, code lgtm

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--watch Now Throws an Error
3 participants