Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retries and error notification in workers #8079

Merged
merged 6 commits into from
Mar 7, 2019

Conversation

rubennorte
Copy link
Contributor

Summary

Handling of errors in workers in jest-worker worker is broken which causes several observable issues:

Test plan

Added unit tests for the workers to make sure messages are re-send to the workers after they're initialized, and an e2e test that makes sure we handle fatal errors in tests properly.

@rubennorte rubennorte requested review from mjesun, SimenB and rickhanlonii and removed request for mjesun March 7, 2019 17:50
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix

@rubennorte rubennorte changed the title Add tests that show that retries are broken in jest-worker Fix retries and error reporting in jest-worker Mar 7, 2019
@rubennorte rubennorte changed the title Fix retries and error reporting in jest-worker Fix retries and error notification in workers Mar 7, 2019
@rubennorte rubennorte merged commit 0c9737e into jestjs:master Mar 7, 2019
@rubennorte rubennorte deleted the worker-fatal-errors branch March 11, 2019 14:31
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jest hangs when a worker runs out of memory
6 participants