Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Prototype Pollution vulnerability in Handlebars dependency #7904

Merged
merged 6 commits into from
Feb 14, 2019
Merged

Fixes Prototype Pollution vulnerability in Handlebars dependency #7904

merged 6 commits into from
Feb 14, 2019

Conversation

tonycassara
Copy link
Contributor

@tonycassara tonycassara commented Feb 14, 2019

Summary

jest-cli is affected by a vulnerability published today on NPM: https://www.npmjs.com/advisories/755

image

This updates the offending package istanbul-api and subsequently istanbul-reports to the version needed to no longer have the handlebars vulnerability.

Test plan

I used yarn upgrade istantbul-api@2.1.1 in the directory jest/packages/jest-cli

…e Pollution found in handlebars dependency
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@tonycassara tonycassara changed the title Updates Jest-CLI with latest istantbul-api package Fixes Prototype Pollution vulnerability in Handlebars dependency Feb 14, 2019
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@SimenB
Copy link
Member

SimenB commented Feb 14, 2019

Thanks @tonycassara!


Note that since the new version is in semver range, you don't need to wait for Jest to publish a new version to avoid the vulnerable dependency - just upgrade locally and make sure it's in your lockfile

@tonycassara
Copy link
Contributor Author

Cool thanks @SimenB ! Will make those changes locally.

@SimenB
Copy link
Member

SimenB commented Feb 14, 2019

npm upgrade handlebars --depth Infinity or yarn upgrade handlebars should do it 🙂

@tonycassara
Copy link
Contributor Author

That worked perfectly thank you

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants