Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate jest-diff to TypeScript #7824

Merged
merged 5 commits into from
Feb 7, 2019
Merged

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Feb 7, 2019

Summary

Built diff:

diff --git c/packages/jest-diff/build/constants.js w/packages/jest-diff/build/constants.js
index 105f35736..2a0d2cd3e 100644
--- c/packages/jest-diff/build/constants.js
+++ w/packages/jest-diff/build/constants.js
@@ -16,8 +16,6 @@ function _interopRequireDefault(obj) {
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
- *
- *
  */
 const NO_DIFF_MESSAGE = _chalk.default.dim(
   'Compared values have no visual difference.'
diff --git c/packages/jest-diff/build/diffStrings.js w/packages/jest-diff/build/diffStrings.js
index a5d12cadf..0dce819a0 100644
--- c/packages/jest-diff/build/diffStrings.js
+++ w/packages/jest-diff/build/diffStrings.js
@@ -9,7 +9,7 @@ var _chalk = _interopRequireDefault(require('chalk'));
 
 var _diffSequences = _interopRequireDefault(require('diff-sequences'));
 
-var _constants = require('./constants.js');
+var _constants = require('./constants');
 
 function _interopRequireDefault(obj) {
   return obj && obj.__esModule ? obj : {default: obj};
@@ -20,8 +20,6 @@ function _interopRequireDefault(obj) {
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
- *
- *
  */
 const DIFF_CONTEXT_DEFAULT = 5;
 const fgPatchMark = _chalk.default.yellow;
diff --git c/packages/jest-diff/build/types.js w/packages/jest-diff/build/types.js
new file mode 100644
index 000000000..ad9a93a7c
--- /dev/null
+++ w/packages/jest-diff/build/types.js
@@ -0,0 +1 @@
+'use strict';

Test plan

Green CI

@@ -65,7 +65,7 @@ type FoundSubsequence = (
) => void;

// Either original functions or wrapped to swap indexes if graph is transposed.
type Callbacks = {
export type Callbacks = {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easier than inspecting the arguments it takes

@SimenB SimenB requested a review from thymikee February 7, 2019 09:28
@codecov-io
Copy link

Codecov Report

Merging #7824 into master will decrease coverage by 0.58%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7824      +/-   ##
==========================================
- Coverage   66.19%   65.61%   -0.59%     
==========================================
  Files         239      236       -3     
  Lines        9040     8861     -179     
  Branches        6        6              
==========================================
- Hits         5984     5814     -170     
+ Misses       3054     3045       -9     
  Partials        2        2
Impacted Files Coverage Δ
packages/jest-circus/src/formatNodeAssertErrors.js 18.18% <ø> (ø) ⬆️
...ackages/jest-jasmine2/src/assertionErrorMessage.js 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4621d05...f06a443. Read the comment docs.

packages/jest-diff/src/diffStrings.ts Outdated Show resolved Hide resolved
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants