Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle builtinModules missing #7565

Merged
merged 3 commits into from
Dec 30, 2018
Merged

fix: handle builtinModules missing #7565

merged 3 commits into from
Dec 30, 2018

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Dec 30, 2018

Summary

See #5855

@rubennorte could you make a new release with this?

Test plan

Har to test since the newest versions of all the versions of node we support has the property. It does work on older versions of node, though.

@montogeek montogeek mentioned this pull request Dec 30, 2018
4 tasks
@codecov-io
Copy link

Codecov Report

Merging #7565 into master will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7565   +/-   ##
=======================================
  Coverage   67.99%   67.99%           
=======================================
  Files         248      248           
  Lines        9490     9490           
  Branches        5        6    +1     
=======================================
  Hits         6453     6453           
  Misses       3035     3035           
  Partials        2        2
Impacted Files Coverage Δ
packages/jest-resolve/src/isBuiltinModule.js 75% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6efeab6...78bbf25. Read the comment docs.

@SimenB SimenB merged commit fd1a693 into jestjs:master Dec 30, 2018
@SimenB SimenB deleted the builtin branch December 30, 2018 20:00
captain-yossarian pushed a commit to captain-yossarian/jest that referenced this pull request Jul 18, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants