Make getFileIterator() return relative paths #7321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafeca
force-pushed
the
relative-paths-in-haste-map
branch
from
635575c
to
252170a
Compare
rubennorte
approved these changes
Nov 2, 2018
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently,
hasteFS.getFileIterator()converts all file paths to absolute, which can be expensive whenjest-haste-maptracks a lot of files.This PR changes the behaviour and makes
getFileIterator()return relative paths (the same way thathasteFSnow accepts relative paths, and creates a new method (getAbsoluteFileIterator()) which returns the absolute paths.Test plan
Unit tests