Pass the normalized configuration to script transformers #7148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubennorte
force-pushed
the
pass-raw-config-to-script-transformers
branch
from
f2fa742
to
f3ec110
Compare
|
Can we remove the configString now? |
|
I think we should preserve it for backwards compatibility. I know next version is major but there's no need to change this (its impact in performance is negligible). |
SimenB
approved these changes
Oct 12, 2018
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Script transformers receive a string with all the configuration to take into account for the cache key. That might cause the generation of new cache keys even if the changes in the configuration don't affect the transformed files. This passes the normalized configuration so the cache key can take into account specific fields in the configuration instead of the whole as a string.
Test plan
Updated a snapshot from the current tests.