Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs]: Add link to jest-extended in expect docs #7078

Merged
merged 3 commits into from
Sep 30, 2018

Conversation

mattphillips
Copy link
Contributor

Summary

Adds a link for jest-extended in the expect docs.

We're still seeing quite a lot of issues around new matchers etc being opened, I think if we link directly out to community matchers in the docs it might help.

Test plan

screen shot 2018-09-30 at 14 31 45

@@ -6,6 +6,8 @@ original_id: expect

When you're writing tests, you often need to check that values meet certain conditions. `expect` gives you access to a number of "matchers" that let you validate different things.

For additional Jest matchers maintained by the Jest Community check out [`jest-extended`](https://github.com/jest-community/jest-extended).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind adding it to all versioned docs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call :)

@SimenB
Copy link
Member

SimenB commented Sep 30, 2018

Great idea!

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@29c7786). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7078   +/-   ##
=========================================
  Coverage          ?   66.63%           
=========================================
  Files             ?      251           
  Lines             ?    10542           
  Branches          ?        3           
=========================================
  Hits              ?     7025           
  Misses            ?     3516           
  Partials          ?        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29c7786...b5c8c94. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@SimenB SimenB merged commit d0e627c into jestjs:master Sep 30, 2018
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants