Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use execa instead of child_process for VCS commands #6987

Merged
merged 3 commits into from
Sep 19, 2018

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Sep 16, 2018

Summary

This is just something I've had on my todo list for quite some time. It simplifies our code a great deal.

Test plan

Green CI

): Promise<Array<Path>> => {
const result = await execa('git', args, {cwd});

return result.stdout
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like it

@SimenB SimenB merged commit c3dc90f into jestjs:master Sep 19, 2018
@SimenB SimenB deleted the execa-in-changed-files branch September 19, 2018 09:42
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants