Resolve #5216

[seanpoulter]

Summary
PR #5054 added a call to replacePathSepForRegex to escape values of the --testPathPattern and <regexForTestFiles> CLI options. Since the Windows path separator and the regular expression special character delimeter are the same character, this can lead to ambiguous patterns (e.g.: app\book\d*\).

This commit:

• Removes escaping CLI args with replacePathSepForRegex to leave them as is unless it's a POSIX path separator on Windows

• Changes the tests in normalize.test.js to run the same test suite for --testPathPattern and <regexForTestFiles>

• Reverts the changes to replacePathSepForRegex from Fix --testPathPattern escaping for '\\' on Windows #5230 but keeps the tests for the intended behavior. It will be complicated to escape the "safe" cases when \ is a path separator and not a regular expression delimeter. Instead of getting fancy, we can urge Windows users to use / or \\ as a path separator.

Test plan
Tests have been updated.

[seanpoulter]

The previous test case results don't change:

This does re-introduce the regression in the escaping of the Watch Usage path pattern. If you enter jest-config\src on Windows, it is escaped and matches the jest-config\src path. If you enter jest-config\\src is also escaped and will not match. 😖 We can clear that one up later, and urge folks to use / instead of \ which is ambiguous as a path sep or regexp special character delimter.

[codecov-io]

Codecov Report

Merging #5269 into master will decrease coverage by 0.15%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5269      +/-   ##
==========================================
- Coverage   61.14%   60.98%   -0.16%     
==========================================
  Files         203      203              
  Lines        6843     6816      -27     
  Branches        4        4              
==========================================
- Hits         4184     4157      -27     
  Misses       2658     2658              
  Partials        1        1

Impacted Files	Coverage Δ
packages/jest-config/src/normalize.js	93.1% <ø> (ø)	⬆️
packages/jest-regex-util/src/index.js	60% <100%> (-29.19%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e95ec14...f901aa4. Read the comment docs.

[cpojer]

Thanks for following up on this @seanpoulter. Ugh, path separators and regex.

[SimenB]

@seanpoulter mind sending a quick PR for the changelog? It's been released in 22.0.6

[seanpoulter]

Would you like a note in the docs to say / is a valid path sep on Windows too, @SimenB?

[SimenB]

Yeah, I think that's a good idea.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.