Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for namespaced babel packages #4918

Merged
merged 2 commits into from
Nov 20, 2017
Merged

Fix support for namespaced babel packages #4918

merged 2 commits into from
Nov 20, 2017

Conversation

danez
Copy link
Contributor

@danez danez commented Nov 19, 2017

Summary

This add support for namespace babel 7 as discussed in #4557

Test plan

It used it in the babel PR babel/babel#6179 and no error appeared.

@codecov-io
Copy link

Codecov Report

Merging #4918 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4918   +/-   ##
=======================================
  Coverage   59.98%   59.98%           
=======================================
  Files         198      198           
  Lines        6563     6563           
  Branches        4        4           
=======================================
  Hits         3937     3937           
  Misses       2626     2626

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9303ecf...9c098e2. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@cpojer cpojer merged commit 27a4c2a into jestjs:master Nov 20, 2017
@danez danez deleted the babel-7 branch November 20, 2017 10:03
@gpeal
Copy link

gpeal commented Nov 20, 2017

@SimenB Will this be pushed to a release soon? It's blocking TS adoption at Airbnb :)

@loganfsmyth
Copy link

Should the peerDependencies block in jest-runtime also be reverted? https://github.com/facebook/jest/blob/ad1d7f73a2bec8a55a51a21609c4dfbedf15c001/packages/jest-runtime/package.json#L34

@cpojer
Copy link
Member

cpojer commented Nov 20, 2017

Happy to accept a revert.

@SimenB
Copy link
Member

SimenB commented Nov 20, 2017

PR for revert: #4923

/cc @cpojer for release

EDIT: Oh, you commented above me 😀

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants