Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade all outdated deps #4425

Merged
merged 5 commits into from
Sep 5, 2017
Merged

Upgrade all outdated deps #4425

merged 5 commits into from
Sep 5, 2017

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Sep 5, 2017

Summary
I've gone through and updated all deps that are not within semver range.

3 notes:

  1. Pretty much all majors are dropping support for node@<4
  2. yargs@9 is currently not tagged as latest (and account for the only code change beyond rollup config)
  3. Upgrading micromatch makes the browser bundling fail (complete refactor micromatch/micromatch#76)
{ Error: Illegal reassignment to import 'commonjsHelpers'
    at error (/Users/simbekkh/repos/jest/node_modules/rollup/dist/rollup.js:170:12)
    at Module.error$1 [as error] (/Users/simbekkh/repos/jest/node_modules/rollup/dist/rollup.js:8007:2)
    at disallowIllegalReassignment (/Users/simbekkh/repos/jest/node_modules/rollup/dist/rollup.js:5556:16)
    at Node.bind (/Users/simbekkh/repos/jest/node_modules/rollup/dist/rollup.js:5634:3)
    at /Users/simbekkh/repos/jest/node_modules/rollup/dist/rollup.js:5291:50
    at Node.eachChild (/Users/simbekkh/repos/jest/node_modules/rollup/dist/rollup.js:5308:5)
    at Node.bind (/Users/simbekkh/repos/jest/node_modules/rollup/dist/rollup.js:5291:7)
    at Module.bindReferences (/Users/simbekkh/repos/jest/node_modules/rollup/dist/rollup.js:7984:8)
    at /Users/simbekkh/repos/jest/node_modules/rollup/dist/rollup.js:9316:62
    at Array.forEach (<anonymous>)
  code: 'ILLEGAL_NAMESPACE_REASSIGNMENT',
  pos: 242,
  loc:
   { file: '/Users/simbekkh/repos/jest/node_modules/base/utils.js',
     line: 9,
     column: 0 },
  frame: ' 7: var utils = require$$0(commonjsHelpers.commonjsRequire);\n 8: var fn = commonjsHelpers.commonjsRequire;\n 9: commonjsHelpers.commonjsRequire = utils; // eslint-disable-line\n    ^\n10: \n11: /**' }

Test plan
./jest

.alias('help', 'h')
.options(args.options)
.epilogue(args.docs)
.check(args.check).argv;
.check(args.check)
.version(false).argv;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could remove the custom version code - difference is a missing v before the version number in yarg's implementation

@SimenB SimenB mentioned this pull request Sep 5, 2017
@codecov-io
Copy link

codecov-io commented Sep 5, 2017

Codecov Report

Merging #4425 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4425   +/-   ##
=======================================
  Coverage   56.84%   56.84%           
=======================================
  Files         191      191           
  Lines        6472     6472           
  Branches        6        6           
=======================================
  Hits         3679     3679           
  Misses       2790     2790           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1517391...3013a8a. Read the comment docs.

@cpojer cpojer merged commit 4398ccb into jestjs:master Sep 5, 2017
@SimenB SimenB deleted the upgrade-deps branch September 5, 2017 15:21
@SimenB SimenB mentioned this pull request Sep 7, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants