Force message in matchers to always be a function #3972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Thank you very much for your contribution. |
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
* Force message in matchers to always be a function * Rename variable back to message instead of messageFn
nigelzor
added a commit
to nigelzor/enzyme-matchers
that referenced
this pull request
Aug 25, 2017
blainekasten
pushed a commit
to enzymejs/enzyme-matchers
that referenced
this pull request
Aug 29, 2017
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#3921
getMessagefunctionstringwas being returned, instead of afunctionChecked the documentation, which already says:
Test plan
All tests pass.
Did not add any new test. Perhaps a test should be added for when we still pass a
string? Basically, it should throw an error:VM189:1 Uncaught TypeError: message is not a functionAdditionally we could
try/catchand default toNo message was specified for this matcher.if a wrong type is supplied formessage.