Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define separate type for pretty-format plugin Options #3802

Merged
merged 3 commits into from
Jun 26, 2017

Conversation

pedrottimark
Copy link
Contributor

@pedrottimark pedrottimark commented Jun 12, 2017

Summary

The type improvements in #3095 accidentally added edgeSpacing and spacing to the public interface of pretty-format

EDIT: in plugins, replace Options with new minimal PluginOptions type

Test plan

Jest

@@ -40,6 +38,12 @@ export type Options = {|
|},
|};

export type Options = {|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about PluginOptions? We could leave the old name of PrettyOptions then.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you for good direction.

@codecov-io
Copy link

Codecov Report

Merging #3802 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3802   +/-   ##
=======================================
  Coverage   58.01%   58.01%           
=======================================
  Files         195      195           
  Lines        6741     6741           
  Branches        6        6           
=======================================
  Hits         3911     3911           
  Misses       2827     2827           
  Partials        3        3
Impacted Files Coverage Δ
...pretty-format/src/plugins/immutable_ordered_map.js 100% <ø> (ø) ⬆️
.../pretty-format/src/plugins/react_test_component.js 100% <ø> (ø) ⬆️
...s/pretty-format/src/plugins/lib/print_immutable.js 100% <ø> (ø) ⬆️
...ckages/pretty-format/src/plugins/immutable_list.js 100% <ø> (ø) ⬆️
...kages/pretty-format/src/plugins/immutable_stack.js 100% <ø> (ø) ⬆️
...ackages/pretty-format/src/plugins/immutable_set.js 100% <ø> (ø) ⬆️
packages/pretty-format/src/plugins/convert_ansi.js 100% <ø> (ø) ⬆️
...pretty-format/src/plugins/immutable_ordered_set.js 100% <ø> (ø) ⬆️
packages/pretty-format/src/index.js 98.05% <ø> (ø) ⬆️
...ackages/pretty-format/src/plugins/react_element.js 100% <ø> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1199558...ac1a244. Read the comment docs.

@cpojer
Copy link
Member

cpojer commented Jun 26, 2017

Sure!

@cpojer cpojer merged commit 3d45888 into jestjs:master Jun 26, 2017
@pedrottimark pedrottimark deleted the plugin-options branch June 27, 2017 19:33
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
* Define separate type for pretty-format plugin Options

* Rename separate type as PluginOptions
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants