Escape double quotes in attribute values in HTMLElement plugin

[pedrottimark]

Summary

Another breaking change. A few more to come. Unlike ReactElement and ReactTestComponent plugins, which call print function to escape double quotes

<div
  title="\"escape\""
/>

a new test for HTMLElement plugin fails before I replace template literal with print function:

<div
-  title="\"escape\""
+  title=""escape""
/>

Proposed: To push correctness, consistency, and performance, let’s refactor common code from HTMLElement, ReactElement, and ReactTestComponent in 3 steps:

1. printProps
2. printChildren
3. printElement

What do you think of pretty-format/src/plugins/lib/markup.js as a file name?

Test plan

Added a test

[codecov-io]

Codecov Report

Merging #3797 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #3797   +/-   ##
=======================================
  Coverage   58.01%   58.01%           
=======================================
  Files         195      195           
  Lines        6741     6741           
  Branches        6        6           
=======================================
  Hits         3911     3911           
  Misses       2827     2827           
  Partials        3        3

Impacted Files	Coverage Δ
packages/pretty-format/src/plugins/html_element.js	94.11% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1199558...b70dd00. Read the comment docs.

[cpojer]

Please rebase

[pedrottimark]

Yes

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.