Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide regex visualization for testRegex #3758

Merged
merged 2 commits into from
Jun 8, 2017

Conversation

miguelcg
Copy link

@miguelcg miguelcg commented Jun 7, 2017

Summary
Closes #3730. Provides a visualization of the regex specified in testRegex.

CC @thymikee

Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the little nit and I'm good :)

@@ -518,6 +518,18 @@ inside of `__tests__` folders, as well as any files with a suffix of `.test` or
or `spec.js`. See also [`testMatch` [array<string>]](#testmatch-array-string), but note
that you cannot specify both options.

The following is a visualization of the regex `(/__tests__/.*|(\\.|/)(test|spec))\\.jsx?$`:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-The following is a visualization of the regex `(/__tests__/.*|(\\.|/)(test|spec))\\.jsx?$`:
+The following is a visualization of the default regex :

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, no problem :)

@thymikee
Copy link
Collaborator

thymikee commented Jun 7, 2017

Thank you!

@codecov-io
Copy link

codecov-io commented Jun 7, 2017

Codecov Report

Merging #3758 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3758   +/-   ##
=======================================
  Coverage   62.63%   62.63%           
=======================================
  Files         183      183           
  Lines        6702     6702           
  Branches        6        6           
=======================================
  Hits         4198     4198           
  Misses       2501     2501           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b254715...25220e0. Read the comment docs.

@cpojer cpojer merged commit c120042 into jestjs:master Jun 8, 2017
@cpojer
Copy link
Member

cpojer commented Jun 8, 2017

Nice!

@orta
Copy link
Member

orta commented Jun 8, 2017

This is great work 👍

tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
* Provide regex visualization for testRegex

* Update Configuration.md
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation does not contain file structure/naming conventions
7 participants