Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/transform refresh #3334

Merged
merged 4 commits into from
Apr 20, 2017
Merged

Conversation

lo-tp
Copy link
Contributor

@lo-tp lo-tp commented Apr 20, 2017

Summary
Correct the bug describe in issue3333

Test plan

Test added and passed.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov-io
Copy link

codecov-io commented Apr 20, 2017

Codecov Report

Merging #3334 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3334   +/-   ##
=======================================
  Coverage   65.07%   65.07%           
=======================================
  Files         178      178           
  Lines        6539     6539           
  Branches        4        4           
=======================================
  Hits         4255     4255           
  Misses       2283     2283           
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-runtime/src/transform.js 89.4% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8724132...cdef948. Read the comment docs.

@cpojer cpojer merged commit 554e884 into jestjs:master Apr 20, 2017
@cpojer
Copy link
Member

cpojer commented Apr 20, 2017

Thank you! I removed some of the changes you made and took a note to update this code soon because we are refactoring how configurations are working.

skovhus pushed a commit to skovhus/jest that referenced this pull request Apr 29, 2017
* Retransform if the relevant configuration is changed

* Correct lint errors

* Write unit test

* Some reverts.
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
* Retransform if the relevant configuration is changed

* Correct lint errors

* Write unit test

* Some reverts.
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants