Make testNamePattern and testPathPattern play better together #3327
Conversation
|
What should be the correct UI for this? |
rogeliog
changed the title
| @@ -40,9 +40,12 @@ module.exports = class TestNamePatternPrompt { | |||
| this._prompt = prompt; | |||
| } | |||
|
|
|||
| run(onSuccess: Function, onCancel: Function) { | |||
| run(onSuccess: Function, onCancel: Function, options) { | |||
|
Please make sure to use the right prettier configuration (run with How about we change the summary in watch mode to show "Active filters: …" instead of "Ran all test suites"? That way you don't have to repeat yourself when typing "w" and it doesn't add any more text to the watch mode. |
|
But if we just change the test summary copy, how would it work when the screen has been cleared? |
|
Hmm, that's a good point :( |
Codecov Report
@@ Coverage Diff @@
## master #3327 +/- ##
=========================================
+ Coverage 64.12% 64.2% +0.08%
=========================================
Files 176 176
Lines 6531 6546 +15
Branches 4 4
=========================================
+ Hits 4188 4203 +15
Misses 2342 2342
Partials 1 1
Continue to review full report at Codecov.
|
…#3327) * Bring back filter by test name * Add Active Filters UI * Add tests * Add appropritate flow types * Run prettier * Fix tests
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This is part of set of polish PRs for the typeaheads #2595
Summary
This adds the ability to clear the "active filters" and it also makes them work better together.
Test plan
Added some tests
This PR still has a UI issue that needs to be resolved... The test summary also shows the active filters... what do you think that it is the best way to move forward with this?
