Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(@jest/core, jest-watcher)!: rework and clean up PatternPrompt and its derived classes #12591

Merged
merged 2 commits into from
Mar 22, 2022
Merged

refactor(@jest/core, jest-watcher)!: rework and clean up PatternPrompt and its derived classes #12591

merged 2 commits into from
Mar 22, 2022

Conversation

mrazauskas
Copy link
Contributor

Summary

Just a few simple TODOs:

  • entityName became a parameter of the constructor of the PatternPrompt class of jest-watcher;
  • underscored methods were marked private / protected in the derived classes;
  • some unused code removed (might be I misunderstood, the lines look unused internally).

Test plan

Green CI.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimenB SimenB merged commit abca0fe into jestjs:main Mar 22, 2022
@mrazauskas mrazauskas deleted the refactor-PatternPrompt branch March 22, 2022 07:41
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants