Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resolver): support node prefix from ESM #11817

Merged
merged 11 commits into from
Sep 8, 2021

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Sep 7, 2021

Summary

See #11802 (comment)

Underlying issue is resolve only support require (thus node: only works for node 16) - this skips calling resolve at all if we think it's a core module on our side

Test plan

e2e test added

@SimenB SimenB force-pushed the node-prefix-esm branch 2 times, most recently from 2e8ed0f to 1366811 Compare September 8, 2021 06:00
@codecov-commenter
Copy link

Codecov Report

Merging #11817 (3a18ea3) into master (3c511fd) will decrease coverage by 0.10%.
The diff coverage is 31.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11817      +/-   ##
==========================================
- Coverage   69.04%   68.94%   -0.11%     
==========================================
  Files         312      312              
  Lines       16366    16400      +34     
  Branches     4746     4750       +4     
==========================================
+ Hits        11300    11307       +7     
- Misses       5039     5066      +27     
  Partials       27       27              
Impacted Files Coverage Δ
packages/jest-runtime/src/index.ts 57.33% <26.82%> (-1.81%) ⬇️
packages/jest-resolve/src/resolver.ts 56.19% <75.00%> (-0.06%) ⬇️
packages/jest-core/src/collectHandles.ts 73.13% <0.00%> (+2.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 831c3de...3a18ea3. Read the comment docs.

@SimenB SimenB merged commit b1ee6de into jestjs:master Sep 8, 2021
@SimenB SimenB deleted the node-prefix-esm branch September 8, 2021 09:59
IanVS added a commit to IanVS/jest that referenced this pull request Sep 10, 2021
IanVS added a commit to IanVS/jest that referenced this pull request Sep 13, 2021
@github-actions
Copy link

github-actions bot commented Oct 9, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants