Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make testFailureExitCode compatible with bail option #10958

Merged
merged 7 commits into from
Dec 24, 2020
Merged

Make testFailureExitCode compatible with bail option #10958

merged 7 commits into from
Dec 24, 2020

Conversation

fazouane-marouane
Copy link
Contributor

@fazouane-marouane fazouane-marouane commented Dec 17, 2020

Summary

Calling jest with option "testFailureExitCode" works as expected. However, when combined with option "bail" it always fails with exit code "1" instead of the exit code provided with "testFailureExitCode".

Test plan

There's a test case in this PR that demonstrates the issue.

@@ -21,7 +21,7 @@ const HG = 'hg --config ui.username=jest_test';

const gitVersionSupportsInitialBranch = (() => {
const {stdout} = run(`${GIT} --version`);
const gitVersion = stdout.split(' ').slice(-1)[0];
const gitVersion = stdout;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was necessary fix since on my machine, it gives git version 2.24.3 (Apple Git-128)

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit f171d38 into jestjs:master Dec 24, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants