Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move jest-runtime CLI into jest-repl #10016

Merged
merged 1 commit into from
Nov 15, 2020

Conversation

ghostd
Copy link
Contributor

@ghostd ghostd commented May 10, 2020

Fixes #10011

Summary

Move jest-runtime CLI into jest-repl to break some circular dependencies

For now, i just moved the code into jest-repl. I think we should wait for complains before deeply merge the CLI code into the REPL code. If no one requires us to extract the CLI into its own package, we can merge it for Jest 28/29.

Test plan

The CLI tests has been moved with the code.

@ghostd ghostd force-pushed the move-runtime-cli-into-repl branch from 457b17f to e29c313 Compare May 10, 2020 11:16
@ghostd ghostd changed the title Move jest-runtime CLI into jest-repl WIP: Move jest-runtime CLI into jest-repl May 10, 2020
@ghostd ghostd force-pushed the move-runtime-cli-into-repl branch from e29c313 to 9612f45 Compare May 10, 2020 11:43
@ghostd ghostd force-pushed the move-runtime-cli-into-repl branch 3 times, most recently from bc12a3f to 1f3f457 Compare May 10, 2020 21:33
@codecov-io
Copy link

Codecov Report

Merging #10016 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10016      +/-   ##
==========================================
- Coverage   64.00%   63.99%   -0.01%     
==========================================
  Files         297      296       -1     
  Lines       12528    12527       -1     
  Branches     3093     3093              
==========================================
- Hits         8018     8017       -1     
  Misses       3860     3860              
  Partials      650      650              
Impacted Files Coverage Δ
packages/jest-runtime/src/index.ts 56.08% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e0eeed...1c181ec. Read the comment docs.

@ghostd ghostd force-pushed the move-runtime-cli-into-repl branch from 1c181ec to 1cc8b7a Compare May 11, 2020 15:58
@ghostd ghostd changed the title WIP: Move jest-runtime CLI into jest-repl Move jest-runtime CLI into jest-repl May 11, 2020
"@jest/transform": "^26.0.1",
"@jest/types": "^26.0.1",
"@types/yargs": "^15.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@types/yargs is already present in devDependencies, it should be one or the other.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed (and rebased)

@ghostd ghostd force-pushed the move-runtime-cli-into-repl branch from 1cc8b7a to e758c8b Compare June 3, 2020 18:19
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will land in next major 👍

packages/jest-runtime/src/index.ts Outdated Show resolved Hide resolved
packages/jest-runtime/src/index.ts Outdated Show resolved Hide resolved
packages/jest-runtime/src/index.ts Outdated Show resolved Hide resolved
@SimenB SimenB added this to the Jest 27 milestone Jun 4, 2020
@ghostd ghostd force-pushed the move-runtime-cli-into-repl branch from e758c8b to 9687eed Compare June 4, 2020 14:26
@SimenB
Copy link
Member

SimenB commented Nov 14, 2020

@ghostd would you be able to rebase this? If not I can do it 🙂

@ghostd
Copy link
Contributor Author

ghostd commented Nov 14, 2020

@SimenB i rebased the branch. Some tests seem fail (depends on the execution environment?) All tests pass on my box :-/

@SimenB
Copy link
Member

SimenB commented Nov 14, 2020

seems somewhat flakey - I'll investigate tonight or tomorrow. Thanks for rebasing!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
@ghostd ghostd deleted the move-runtime-cli-into-repl branch May 11, 2021 18:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove or extract binary script from jest-runtime
5 participants