Fix progress bar in windows #3626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On windows (cmd, powershell, and cmder) the progress bar was broken. The issue is windows doesnt fully support inverse, and so just renders blank spaces. Changing it to a block character (ascii 219) and removing the inverse fixes this, and should still look the same across other terminals that worked before this change.
RusinovAnton
approved these changes
May 22, 2017
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
On windows (cmd, powershell, and cmder) the progress bar was broken. The issue is windows doesnt fully support inverse, and so just renders blank spaces. Changing it to a block character (ascii 219) and removing the inverse fixes this, and should still look the same across other terminals that worked before this change.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On windows (cmd, powershell, and cmder/conemu) the progress bar was broken. The issue is windows doesnt fully support inverse, and so just renders blank spaces. Changing it to a block character (ascii 219) and removing the inverse fixes this, and should still look the same across other terminals that worked before this change.
Test plan
Not needed(?)