jest-haste-map: simplify watch-mode test structure #3623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanlauliac
changed the title
|
Yeah, wow, this is nice. |
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
* jest-haste-map: simplify watch-mode test structure, first step * jest-haste-map: simplify watch-mode test structure, final step
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to fix the problems we've had with jest not recovering from module duplication. As a first step, I propose we refactor the unit test a little bit so that it's easier to add new new tests. This is two-fold. First, I switched functions over to
async/await, making it easier to read and to reduce nesting. Second, I wrote a wrapper forit()so that we can write each watch-mode test in separate jest test case. That'll gives us better reporting when things break, if they do, and does not really increase complexity, as you can see.This changeset only switches over the very first test case. I'd like to get approval of that technique first, and I'll switch the remaining tests in a separate changeset.
Test plan
I ran: