Fix updateSnapshot resetting after updating snapshots in watch mode (#…

…5256)
jestjs · Jan 15, 2018 · 634e474 · 634e474
1 parent afc0a49
commit 634e474
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/jest-cli/src/__tests__/watch.test.js b/packages/jest-cli/src/__tests__/watch.test.js
@@ -257,6 +257,8 @@ describe('Watch mode flows', () => {
   });
 
   it('Pressing "u" reruns the tests in "update snapshot" mode', () => {
+    globalConfig.updateSnapshot = 'new';
+
     watch(globalConfig, contexts, pipe, hasteMapInstances, stdin);
     runJestMock.mockReset();
 
@@ -270,7 +272,7 @@ describe('Watch mode flows', () => {
     stdin.emit(KEYS.A);
     // updateSnapshot is not sticky after a run.
     expect(runJestMock.mock.calls[1][0].globalConfig).toMatchObject({
-      updateSnapshot: 'none',
+      updateSnapshot: 'new',
       watch: false,
     });
   });

diff --git a/packages/jest-cli/src/watch.js b/packages/jest-cli/src/watch.js
@@ -228,13 +228,15 @@ export default function watch(
         startRun(globalConfig);
         break;
       case KEYS.U:
+        const previousUpdateSnapshot = globalConfig.updateSnapshot;
+
         globalConfig = updateGlobalConfig(globalConfig, {
           updateSnapshot: 'all',
         });
         startRun(globalConfig);
         globalConfig = updateGlobalConfig(globalConfig, {
           // updateSnapshot is not sticky after a run.
-          updateSnapshot: 'none',
+          updateSnapshot: previousUpdateSnapshot,
         });
         break;
       case KEYS.I: