Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any way to specify a custom origin/referer/host? #714

Closed
ekaradon opened this issue Sep 23, 2016 · 6 comments
Closed

Is there any way to specify a custom origin/referer/host? #714

ekaradon opened this issue Sep 23, 2016 · 6 comments
Milestone

Comments

@ekaradon
Copy link
Contributor

Hello,

First, thanks for this project, it is really great!

I want to use it in an existing project because everything looks better with it. However I have to use a custom host project.dev.lan in order to be authorized by the backend part. Is it possible to customize this part without running npm run eject?
I have seen the proxy part, but it does not change the host part in the http header request (origin and referer fields). Is there any way to force it?

I also have to set the port as 80 and not 3000. I know that we can do that through environment variables but I would prefer to have a overriding configuration file. It is easier to make it works on different OS. Same thing for the HTTPS. I prefer a file over an environment variable.

Thank you,

@gaearon
Copy link
Contributor

gaearon commented Sep 23, 2016

#695 will add support for environment overrides file so you'll be able to specify PORT and HTTPS there. Would adding support for HOST be enough for your needs?

@ekaradon
Copy link
Contributor Author

Yep, definitely. The origin and referer fields are deduced through the host and the resource path. So it would work.

@gaearon
Copy link
Contributor

gaearon commented Sep 23, 2016

Happy to review a PR adding support for this. Would you like to work on it?

@ekaradon
Copy link
Contributor Author

OK. Let's do this.

@ekaradon
Copy link
Contributor Author

Here:
#717

@gaearon gaearon added this to the 0.5.0 milestone Sep 23, 2016
@gaearon
Copy link
Contributor

gaearon commented Sep 23, 2016

Fixed via #717. Thanks!

@gaearon gaearon closed this as completed Sep 23, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants