Fix: adapt
function to translate cached prompts
in place.
#889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue #888
It enables the following functionality in order to generate a testset in a language other than English.
Without this fix, this would only work the first time. The first time, when the prompts are translated the "adapt" method changes the prompt instances (that is, in place). Therefore, the generate below uses the translated prompts. However once the prompts are in the cache, running adapt on all prompts doesn't change them "in place" and then
generate
will access the original prompts completely in English. This PR makes this approach to work also when the translated prompts are already cached.I also added the
testset_prompts
variable for convenience.