Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add docs for new entity based metric #674

Merged

Conversation

sky-2002
Copy link
Contributor

Recently I have added a new metric in #667.
This PR adds documentation for that metric.

@shahules786
Copy link
Member

Hey bro @sky-2002 thanks a lot. Like previous, you're blazing fast from idea -> PR.
I have left few suggestions if you could add that too, we can merge this PR

@shahules786 shahules786 self-requested a review February 28, 2024 21:26
**Low entity recall context**: The Taj Mahal is an iconic monument in India. It is a UNESCO World Heritage Site and attracts millions of visitors annually. The intricate carvings and stunning architecture make it a must-visit destination.

````

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a "How was this calculated" section just like here. Helps non-ML users to understand the metric better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thank you.

@shahules786 shahules786 merged commit 5fbd19b into explodinggradients:main Feb 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants