accumulate: fix inefficient example #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intent, I believe, is to show an example that would work and gives correct results but fails the non-strictness test. It was added in d238a33. In order for it to compile, the `xs` needs to be removed (an eta reduction has happened). In order for the results to be correct, final `acc` must be reversed.
|
Nice catch! |
This was referenced Oct 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent, I believe, is to show an example that would work and gives
correct results but fails the non-strictness test. It was added in
d238a33.
In order for it to compile, the
xsneeds to be removed (an etareduction has happened).
In order for the results to be correct, final
accmust be reversed.