Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mcrouter] Wrong memcached service name in configmap #251

Open
dragoangel opened this issue Sep 13, 2023 · 1 comment
Open

[mcrouter] Wrong memcached service name in configmap #251

dragoangel opened this issue Sep 13, 2023 · 1 comment

Comments

@dragoangel
Copy link

dragoangel commented Sep 13, 2023

Describe the bug
Proper naming should be:

{
  "pools": {
    "A": {
      "servers": [
        // hosts of replicated pool, https://github.com/facebook/mcrouter/wiki/Replicated-pools-setup e.g.:
        "mcrouter-memcached-0.mcrouter-memcached.mcrouter.svc.cluster.local:11211",
        "mcrouter-memcached-1.mcrouter-memcached.mcrouter.svc.cluster.local:11211",
        "mcrouter-memcached-2.mcrouter-memcached.mcrouter.svc.cluster.local:11211",
      ]
    }
  },

but by default service names generated as mcrouter-0.mcrouter.mcrouter.svc.cluster.local:11211 resulting in non-working mcrouter, template missing -memcached twice, for pod and for service names.

Version of Helm and Kubernetes:

helm v3.12.3
kubernetes v1.24.15

**Which chart**:
mcrouter

What happened:
wrong configuration applied by default

What you expected to happen:
default config have proper settings to work

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know:

dependencies:
  - name: memcached
    version: ~6.6
    repository: https://charts.bitnami.com/bitnami
    condition: mcrouter.memcached.enabled

condition mcrouter.memcached.enabled should be memcached.enabled?

@dragoangel
Copy link
Author

dragoangel commented Sep 13, 2023

It would be also good to bump Bitnami Memcached chart version to ~6.6 and allow templating route via helm values, as default section could not fit well for everyone, for example "get": "LatestRoute|Pool|A" use just same memcached pod from a pool as described here: facebook/mcrouter#127 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant